RESOLVED FIXED 93462
[Qt] Add unit test for QObject bindings for scriptable plugins 
https://bugs.webkit.org/show_bug.cgi?id=93462
Summary [Qt] Add unit test for QObject bindings for scriptable plugins
Simon Hausmann
Reported 2012-08-08 04:44:57 PDT
[Qt] Add unit test for QObject bindings for scriptable plugins
Attachments
Patch (3.05 KB, patch)
2012-08-08 04:48 PDT, Simon Hausmann 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-08-08 04:48:01 PDT
Created attachment 157182 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-08-08 05:04:17 PDT
Comment on attachment 157182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189 > + TestPluginWidget() > + { } why on separate line? > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192 > + int slotWithReturnValue() { return 42; } Lovely number :-) > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206 > + virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &) why not webkit style?
Simon Hausmann
Comment 3 2012-08-08 06:12:20 PDT
(In reply to comment #2) > (From update of attachment 157182 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review > > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189 > > + TestPluginWidget() > > + { } > > why on separate line? OOps. > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192 > > + int slotWithReturnValue() { return 42; } > > Lovely number :-) > > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206 > > + virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &) > > why not webkit style? Thanks, will fix these before landing.
Simon Hausmann
Comment 4 2012-08-08 06:14:37 PDT
Committed r125029: <http://trac.webkit.org/changeset/125029>
Note You need to log in before you can comment on or make changes to this bug.