RESOLVED FIXED82942
Rename SpellingCorrectionController to AlternativeTextController. 
https://bugs.webkit.org/show_bug.cgi?id=82942
Summary Rename SpellingCorrectionController to AlternativeTextController.
Jia Pu
Reported 2012-04-02 13:39:21 PDT
We'd like to submit the big patch in bug 82503 with several stages. This patch renames class SpellingCorrectionController to AlternativeTextController, since it will also be used to control alternative dictation input on OSX.
Attachments
Patch (v1) (176.36 KB, patch)
2012-04-02 13:58 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Patch (V2) (177.25 KB, patch)
2012-04-02 17:44 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Attempt to fix gtk build. (178.45 KB, patch)
2012-04-02 18:55 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Attempt to fix gtk and windows build. (179.20 KB, patch)
2012-04-02 19:06 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Resolved conflict with TOT. (179.02 KB, patch)
2012-04-03 10:03 PDT, Jia Pu 		enrica: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jia Pu
Comment 1 2012-04-02 13:42:54 PDT
<rdar://problem/11168786>
Jia Pu
Comment 2 2012-04-02 13:58:53 PDT
Created attachment 135179 [details] Patch (v1)
Jia Pu
Comment 3 2012-04-02 17:44:11 PDT
Created attachment 135244 [details] Patch (V2)
Jia Pu
Comment 4 2012-04-02 17:44:30 PDT
Updated to TOT.
WebKit Review Bot
Comment 5 2012-04-02 17:50:51 PDT
Attachment 135244 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/editing/AlternativeTextController.h:75: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 6 2012-04-02 17:52:54 PDT
Comment on attachment 135244 [details] Patch (V2) Attachment 135244 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12311823
Jia Pu
Comment 7 2012-04-02 18:55:33 PDT
Created attachment 135254 [details] Attempt to fix gtk build.
Jia Pu
Comment 8 2012-04-02 19:06:53 PDT
Created attachment 135257 [details] Attempt to fix gtk and windows build.
Hajime Morrita
Comment 9 2012-04-02 21:35:21 PDT
Comment on attachment 135257 [details] Attempt to fix gtk and windows build. Thanks for splitting the orignal one. This looks OK. Please wait until bots become green.
WebKit Review Bot
Comment 10 2012-04-03 07:51:50 PDT
Comment on attachment 135257 [details] Attempt to fix gtk and windows build. Rejecting attachment 135257 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebKit/mac/ChangeLog patching file Source/WebKit/mac/WebCoreSupport/CorrectionPanel.h patching file Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm patching file Source/WebKit/mac/WebCoreSupport/WebEditorClient.h patching file Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm patching file Source/WebKit/mac/WebView/WebView.mm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12323124
Jia Pu
Comment 11 2012-04-03 10:03:20 PDT
Created attachment 135349 [details] Resolved conflict with TOT.
Enrica Casucci
Comment 12 2012-04-03 13:35:39 PDT
Comment on attachment 135349 [details] Resolved conflict with TOT. It is a giant patch!
WebKit Review Bot
Comment 13 2012-04-03 14:56:17 PDT
Comment on attachment 135349 [details] Resolved conflict with TOT. Rejecting attachment 135349 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 126079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 126079. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12319405
Jia Pu
Comment 14 2012-04-03 15:23:33 PDT
(In reply to comment #13) > (From update of attachment 135349 [details]) > Rejecting attachment 135349 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > Kit/chromium/third_party/yasm/source/patched-yasm --revision 126079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > 47>At revision 126079. > > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > Updating webkit projects from gyp files... > > Full output: http://queues.webkit.org/results/12319405 hmmm, it's rather difficult to tell from these log what the culprit is. Any suggestion from webkit experts?
Jia Pu
Comment 15 2012-04-03 16:40:46 PDT
Keep running into submission issue. So I manually landed it. Committed r113109: <http://trac.webkit.org/changeset/113109>
Note You need to log in before you can comment on or make changes to this bug.