79449 – Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder

RESOLVED FIXED 79449

Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder

https://bugs.webkit.org/show_bug.cgi?id=79449

Summary Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder

Ashod Nakashian

Reported 2012-02-23 23:07:13 PST

Move FILE_SYSTEM code out of WorkerContext and into the fileapi/WorkerContextFileSystem folder[1]. [1]: https://docs.google.com/spreadsheet/ccc?key=0AppchfQ5mBrEdFlodHlLb0prdEd1ZEZyUHdCbEpoc2c#gid=0

Attachments
Patch (25.93 KB, patch) 2012-02-25 05:39 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Patch (25.93 KB, patch) 2012-02-25 06:07 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Patch (26.68 KB, patch) 2012-02-26 07:57 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Patch (26.68 KB, patch) 2012-02-26 08:14 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Patch (26.73 KB, patch) 2012-02-26 08:37 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Patch (26.87 KB, patch) 2012-02-26 11:13 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Patch (27.34 KB, patch) 2012-02-26 20:25 PST, Ashod Nakashian	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Ashod Nakashian

Comment 1 2012-02-25 05:39:51 PST

Created attachment 128863 [details] Patch

WebKit Review Bot

Comment 2 2012-02-25 05:42:56 PST

Attachment 128863 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/fileapi/WorkerContextFileSystem.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gustavo Noronha (kov)

Comment 3 2012-02-25 05:55:20 PST

Comment on attachment 128863 [details] Patch Attachment 128863 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11632335

Ashod Nakashian

Comment 4 2012-02-25 06:07:23 PST

Created attachment 128864 [details] Patch

WebKit Review Bot

Comment 5 2012-02-25 06:35:18 PST

Comment on attachment 128864 [details] Patch Attachment 128864 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11627441

Philippe Normand

Comment 6 2012-02-25 07:14:13 PST

Comment on attachment 128864 [details] Patch Attachment 128864 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11629405

Collabora GTK+ EWS bot

Comment 7 2012-02-25 08:28:08 PST

Comment on attachment 128864 [details] Patch Attachment 128864 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11626400

Adam Barth

Comment 8 2012-02-25 21:58:40 PST

Comment on attachment 128864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128864&action=review Looks like you're having some trouble building. > Source/WebCore/fileapi/WorkerContextFileSystem.h:44 > + void webkitRequestFileSystem(int type, long long size, PassRefPtr<FileSystemCallback> successCallback, PassRefPtr<ErrorCallback>); > + PassRefPtr<DOMFileSystemSync> webkitRequestFileSystemSync(int type, long long size, ExceptionCode&); > + void webkitResolveLocalFileSystemURL(const String& url, PassRefPtr<EntryCallback> successCallback, PassRefPtr<ErrorCallback>); > + PassRefPtr<EntrySync> webkitResolveLocalFileSystemSyncURL(const String& url, ExceptionCode&); These all should be static and take a WorkerContext as the first argument. Also, WorkerContextFileSystem should have a private constructor and destructor, like DOMWindowFileSystem. > Source/WebCore/workers/WorkerContext.h:130 > + // FIXME: Move these constants to WorkerContextFileSystem. You should be able to move these now. We didn't move them right away in the other patch because of a bug in the code generator that has since been fixed.

Ashod Nakashian

Comment 9 2012-02-26 07:57:42 PST

Created attachment 128915 [details] Patch

Philippe Normand

Comment 10 2012-02-26 08:03:09 PST

Comment on attachment 128915 [details] Patch Attachment 128915 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11627727

WebKit Review Bot

Comment 11 2012-02-26 08:03:21 PST

Attachment 128915 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ashod Nakashian

Comment 12 2012-02-26 08:14:53 PST

Created attachment 128917 [details] Patch

Philippe Normand

Comment 13 2012-02-26 08:18:47 PST

Comment on attachment 128917 [details] Patch Attachment 128917 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11626667

Philippe Normand

Comment 14 2012-02-26 08:27:49 PST

Comment on attachment 128917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128917&action=review > Source/WebCore/GNUmakefile.list.am:4871 > + $(WebCore)/fileapi/WorkerContextFileSystem.idl \ Remove trailing backslah. That should make EWS happier.

Ashod Nakashian

Comment 15 2012-02-26 08:37:41 PST

Created attachment 128918 [details] Patch

Philippe Normand

Comment 16 2012-02-26 08:42:17 PST

Comment on attachment 128918 [details] Patch Attachment 128918 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11627736

Philippe Normand

Comment 17 2012-02-26 08:51:15 PST

Comment on attachment 128918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128918&action=review > Source/WebCore/GNUmakefile.list.am:4871 > $(WebCore)/fileapi/MetadataCallback.idl > + $(WebCore)/fileapi/WorkerContextFileSystem.idl \ This won't work either. Move the backslash to the end of previous line: $(WebCore)/fileapi/MetadataCallback.idl \ $(WebCore)/fileapi/WorkerContextFileSystem.idl (without forgetting the tabulations :)

Adam Barth

Comment 18 2012-02-26 09:35:25 PST

Comment on attachment 128918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128918&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Looks like you're getting close. You'll need to remove this land before we can land your patch. I'd probably replace it with a sentence that says that there shouldn't be any change in behavior from this patch (and therefore there's nothing to test).

Ashod Nakashian

Comment 19 2012-02-26 11:13:50 PST

Created attachment 128923 [details] Patch

WebKit Review Bot

Comment 20 2012-02-26 11:44:11 PST

Comment on attachment 128923 [details] Patch Attachment 128923 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11632682

Ashod Nakashian

Comment 21 2012-02-26 20:25:18 PST

Created attachment 128942 [details] Patch

Ashod Nakashian

Comment 22 2012-02-28 09:24:36 PST

The patch has passed the build scripts and is ready for review.

Adam Barth

Comment 23 2012-02-28 11:04:22 PST

Comment on attachment 128942 [details] Patch Looks great. Thanks.

WebKit Review Bot

Comment 24 2012-02-28 11:53:12 PST

Comment on attachment 128942 [details] Patch Clearing flags on attachment: 128942 Committed r109133: <http://trac.webkit.org/changeset/109133>

WebKit Review Bot

Comment 25 2012-02-28 11:53:21 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebCore Misc.

Assignee

Nobody

Reported

2012-02-23 23:07 PST

Modified

2012-02-28 11:53 PST History

CC List

10 users Show

URL

Keywords

Depends on

Blocks

79327

Dependencies

tree graph