RESOLVED FIXED 77905
Change baselinePosition and lineHeight to LayoutUnit 
https://bugs.webkit.org/show_bug.cgi?id=77905
Summary Change baselinePosition and lineHeight to LayoutUnit
Emil A Eklund
Reported 2012-02-06 15:07:43 PST
Change baselinePosition and lineHeight to return LayoutUnit instead of int.
Attachments
Patch (19.47 KB, patch)
2012-02-06 15:49 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (19.56 KB, patch)
2012-02-06 18:18 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-02-06 15:49:26 PST
Created attachment 125720 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-06 17:53:20 PST
Comment on attachment 125720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125720&action=review > Source/WebCore/ChangeLog:9 > + Change the virtual baselinePosition and lineHeight methods to use > + LayoutUnits in preparation for the switch over to subpixel layout. It would be better to explain why these functions should be using these types in the Changelog. You don't have to detail each one, but a setence like: RenderTheme deals only with rendering objects, which will be positioned by LayoutUnit coordinates. or something like that.
Emil A Eklund
Comment 3 2012-02-06 18:05:16 PST
> It would be better to explain why these functions should be using these types in the Changelog. Good point, I'll update the description to be more descriptive.
Emil A Eklund
Comment 4 2012-02-06 18:18:19 PST
Created attachment 125745 [details] Patch
Emil A Eklund
Comment 5 2012-02-06 19:01:24 PST
Thanks!
WebKit Review Bot
Comment 6 2012-02-06 20:26:34 PST
Comment on attachment 125745 [details] Patch Clearing flags on attachment: 125745 Committed r106900: <http://trac.webkit.org/changeset/106900>
WebKit Review Bot
Comment 7 2012-02-06 20:26:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.