REOPENED 77724
Improve http-equiv content-language parsing 
https://bugs.webkit.org/show_bug.cgi?id=77724
Summary Improve http-equiv content-language parsing
Matt Falkenhagen
Reported 2012-02-03 01:44:40 PST
Spun off of bug 76701. We should figure out what behavior we want for content-language edge cases (whitespace, missing content, etc.) Also, how to handle dynamic changes to meta.
Attachments
Patch (18.73 KB, patch)
2012-02-08 02:30 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
tests for dynamic changes and comma-separated list (14.01 KB, patch)
2012-02-08 22:00 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2012-02-03 11:13:01 PST
To me it seems there are two parts to this: 1) Adding much more extensive test coverage. 2) Fixing any bugs we find. We should do (1) first and land the tests ASAP.
Matt Falkenhagen
Comment 2 2012-02-08 02:30:28 PST
Created attachment 126035 [details] Patch
Matt Falkenhagen
Comment 3 2012-02-08 02:53:17 PST
I uploaded a patch with some tests. I tried to choose reasonable expectations and documented what the spec says and what I've observed other browsers do. The current implementation is failing some of these expectations, which I'm not sure is acceptable or not when adding new tests. On the other hand it didn't quite feel correct to make expectations based only on what the current implementation does. I haven't yet looked into dynamic changes to meta, as Darin suggested in bug 76701. I'll try that next. Also a test for a comma-separated list of languages.
Alexey Proskuryakov
Comment 4 2012-02-08 08:59:32 PST
Comment on attachment 126035 [details] Patch Looks reasonable.
WebKit Review Bot
Comment 5 2012-02-08 17:42:02 PST
Comment on attachment 126035 [details] Patch Clearing flags on attachment: 126035 Committed r107159: <http://trac.webkit.org/changeset/107159>
WebKit Review Bot
Comment 6 2012-02-08 17:42:07 PST
All reviewed patches have been landed. Closing bug.
Matt Falkenhagen
Comment 7 2012-02-08 21:47:25 PST
Thanks for the review. I'll upload the next patch with tests for dynamic changes and comma-separated list.
Matt Falkenhagen
Comment 8 2012-02-08 22:00:37 PST
Created attachment 126238 [details] tests for dynamic changes and comma-separated list
Alexey Proskuryakov
Comment 9 2012-02-08 23:11:14 PST
Comment on attachment 126238 [details] tests for dynamic changes and comma-separated list Actually, I don't think that this kind of tests belong to fast/text. It's pure DOM/CSS. cq+ because some tests have already been landed, but please consider moving them.
WebKit Review Bot
Comment 10 2012-02-09 01:50:23 PST
Comment on attachment 126238 [details] tests for dynamic changes and comma-separated list Clearing flags on attachment: 126238 Committed r107200: <http://trac.webkit.org/changeset/107200>
WebKit Review Bot
Comment 11 2012-02-09 01:50:28 PST
All reviewed patches have been landed. Closing bug.
Matt Falkenhagen
Comment 12 2012-02-09 18:03:36 PST
Thanks for the review. Reopening since just tests have landed.
Darin Adler
Comment 13 2012-02-09 18:38:15 PST
Next time please use multiple bug reports. There’s no good reason to use one report for multiple patches when we can file others and have them blocking the original.
Matt Falkenhagen
Comment 14 2017-07-18 17:13:47 PDT
As far as I recall by re-reading this thread, the remaining task here is part 2) from comment 1: "2) Fixing any bugs we find." I think it may be acceptable to just close this bug and open a new one if bugs are indeed found based on what was landed in comment 5 and comment 10.
Note You need to log in before you can comment on or make changes to this bug.