RESOLVED DUPLICATE of bug 83440 75071
Reduce per-attribute overhead by no longer heap-allocating Attribute objects 
https://bugs.webkit.org/show_bug.cgi?id=75071
Summary Reduce per-attribute overhead by no longer heap-allocating Attribute objects
Darin Adler
Reported 2011-12-21 23:41:35 PST
It seems that we do not need to heap-allocate Attribute objects. Reference counting each one seems like overkill. There must be a way to have the Vector of attributes contain the attributes themselves rather than just heap pointers. These are not variable-size objects.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-12-21 23:44:34 PST
But Attribute objects are exposed to JavaScript and can be removed from / added back to NamedNodeMap. How are we going to do that if they were a part of NamedNodeMap?
Darin Adler
Comment 2 2011-12-21 23:46:19 PST
(In reply to comment #1) > But Attribute objects are exposed to JavaScript and can be removed from / added back to NamedNodeMap. How are we going to do that if they were a part of NamedNodeMap? Attr objects are exposed to JavaScript. Attribute objects are internal to WebKit and not exposed to JavaScript.
Darin Adler
Comment 3 2011-12-21 23:47:18 PST
(In reply to comment #2) > (In reply to comment #1) > > But Attribute objects are exposed to JavaScript and can be removed from / added back to NamedNodeMap. How are we going to do that if they were a part of NamedNodeMap? > > Attr objects are exposed to JavaScript. Attribute objects are internal to WebKit and not exposed to JavaScript. Supporting Attr may still pose some challenges, but I am pretty sure that we don’t need to start doing all that heap allocating until people actually use Attr.
Ryosuke Niwa
Comment 4 2012-07-23 00:14:33 PDT
This has been done in http://trac.webkit.org/changeset/114870 by anttik.
Antti Koivisto
Comment 5 2012-07-23 07:32:34 PDT
By kling! *** This bug has been marked as a duplicate of bug 83440 ***
Lucas Forschler
Comment 6 2019-02-06 09:03:18 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.