RESOLVED FIXED 71698
Remove initWebKitAnimationEvent method 
https://bugs.webkit.org/show_bug.cgi?id=71698
Summary Remove initWebKitAnimationEvent method
Dominic Cooney
Reported 2011-11-07 09:02:27 PST
Code Search indicates that nobody uses this. Now that WebKitAnimationEvent has a constructor, we should remove this method.
Attachments
Patch (7.42 KB, patch)
2011-11-07 09:06 PST, Dominic Cooney 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-11-07 09:06:16 PST
Created attachment 113878 [details] Patch
Ojan Vafai
Comment 2 2011-11-07 09:24:19 PST
Comment on attachment 113878 [details] Patch Are there already tests for the constructor version?
Dominic Cooney
Comment 3 2011-11-07 09:46:17 PST
(In reply to comment #2) > (From update of attachment 113878 [details]) > Are there already tests for the constructor version? Yes, in fast/events/constructors/webkit-animation-event-constructor.html. Should I note that in the ChangeLog?
Ojan Vafai
Comment 4 2011-11-07 10:13:41 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 113878 [details] [details]) > > Are there already tests for the constructor version? > > Yes, in fast/events/constructors/webkit-animation-event-constructor.html. Should I note that in the ChangeLog? No, that's fine. I just wanted to be sure we weren't losing test coverage.
Dominic Cooney
Comment 5 2011-11-07 10:53:31 PST
Comment on attachment 113878 [details] Patch Don’t want to commit this yet until I confirm the CSS3 Animations spec deprecates initAnimationEvent.
Dominic Cooney
Comment 6 2011-12-25 22:06:43 PST
Comment on attachment 113878 [details] Patch Remove this from CQ for now. I filed <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> to change the CSS Animations spec to remove this method.
Ojan Vafai
Comment 7 2011-12-26 10:07:17 PST
I don't think you need to wait for the spec to be updated here. The platform as a whole is clearly moving in this direction, so it seems very unlikely to me that this spec won't be updated eventually to match. The longer this stays in trunk, the more likely we'll get stuck unable to remove it due to compatibility concerns. Filing the spec bug is important of course.
Dominic Cooney
Comment 8 2011-12-27 18:48:03 PST
Committed r103751: <http://trac.webkit.org/changeset/103751>
Note You need to log in before you can comment on or make changes to this bug.