RESOLVED FIXED 66149
Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units 
https://bugs.webkit.org/show_bug.cgi?id=66149
Summary Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
Levi Weintraub
Reported 2011-08-12 11:41:29 PDT
Ongoing conversion effort...
Attachments
Patch (23.92 KB, patch)
2011-08-12 12:42 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.08 KB, patch)
2011-08-12 13:49 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-08-12 12:42:48 PDT
Created attachment 103797 [details] Patch
Eric Seidel (no email)
Comment 2 2011-08-12 13:17:09 PDT
Comment on attachment 103797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103797&action=review > Source/WebCore/rendering/RenderListBox.cpp:484 > + IntPoint currentMousePosition = roundedIntPoint(frame()->eventHandler()->currentMousePosition()); Sad times. That we're rounding. :( > Source/WebCore/rendering/RenderListBox.cpp:526 > + LayoutUnit offsetX = destination.x() - absPos.x(); > + LayoutUnit offsetY = destination.y() - absPos.y(); Sounds like a size to me. :(
Levi Weintraub
Comment 3 2011-08-12 13:49:34 PDT
Created attachment 103810 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-08-12 14:35:17 PDT
Comment on attachment 103810 [details] Patch for landing Clearing flags on attachment: 103810 Committed r92998: <http://trac.webkit.org/changeset/92998>
WebKit Review Bot
Comment 5 2011-08-12 14:35:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.