RESOLVED FIXED 66146
Switch RenderTable* to new layout types 
https://bugs.webkit.org/show_bug.cgi?id=66146
Summary Switch RenderTable* to new layout types
Levi Weintraub
Reported 2011-08-12 10:45:48 PDT
Ongoing conversion.
Attachments
Patch (23.37 KB, patch)
2011-08-12 10:51 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (67.61 KB, patch)
2011-08-12 13:14 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-08-12 10:51:58 PDT
Created attachment 103781 [details] Patch
Eric Seidel (no email)
Comment 2 2011-08-12 12:04:03 PDT
Comment on attachment 103781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103781&action=review > Source/WebCore/rendering/RenderTableRow.cpp:186 > + return LayoutRect(); This function still returns an IntRect, though no? > Source/WebCore/rendering/RenderTableSection.cpp:318 > + LayoutUnit bdesc = 0; > + LayoutUnit ch = m_grid[r].logicalHeight.calcMinValue(0); Such helpful variable names! > Source/WebCore/rendering/RenderTableSection.cpp:342 > - statePusher.push(this, IntSize(x(), y())); > + statePusher.push(this, LayoutSize(x(), y())); I'm surprised there isn't already a location() which could be converted to a point directly. > Source/WebCore/rendering/RenderTableSection.cpp:432 > + LayoutUnit dh = toAdd; Oh goodie! dh! Of course. :) > Source/WebCore/rendering/RenderTableSection.cpp:571 > + LayoutUnit b = cell->cellBaselinePosition(); b, yes-sir. b it is! > Source/WebCore/rendering/RenderTableSection.cpp:617 > + view()->addLayoutDelta(LayoutSize(oldCellRect.x() - cell->x(), oldCellRect.y() - cell->y())); rect.location - rect.location? > Source/WebCore/rendering/RenderTableSection.cpp:631 > + LayoutSize childOffset(cell->x() - oldCellRect.x(), cell->y() - oldCellRect.y()); cell->location() - oldcellRect.location()?
Levi Weintraub
Comment 3 2011-08-12 12:57:22 PDT
Thanks for the review! I'm fixing the things you mentioned and landing :)
Levi Weintraub
Comment 4 2011-08-12 13:14:40 PDT
Created attachment 103805 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-08-12 14:02:00 PDT
Comment on attachment 103805 [details] Patch for landing Clearing flags on attachment: 103805 Committed r92992: <http://trac.webkit.org/changeset/92992>
WebKit Review Bot
Comment 6 2011-08-12 14:02:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.