WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
63164
CompositeEditingCommand::splitTreeToNode should split to a position instead.
https://bugs.webkit.org/show_bug.cgi?id=63164
Summary
CompositeEditingCommand::splitTreeToNode should split to a position instead.
Annie Sullivan
Reported
2011-06-22 11:55:36 PDT
The method should be renamed splitTree(Position& start, Node*end, enum shouldSplitAncestor). Looking at the callsites makes it clear why we really should to split to a position: * Most of them actually split to a position.containerNode() or position.deprecatedNode() already * InsertListCommand::doApply has a lot of logic for picking the node to split to which would be greatly simplified by splitting to a position * ReplaceSelectionCommand::insertAsListItems has to do some extra splitting of text nodes that would happen automatically in splitNodeToPosition * InsertParagraphSeparatorCommand::doApply() recently regressed because sometimes it would pick the wrong node to split to from the position.
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-01-06 08:07:32 PST
@rniwa - should this be RESOLVED LATER? or this path is abandoned? Thanks!
Ryosuke Niwa
Comment 2
2023-01-09 11:01:05 PST
Yeah, this is Later at this point.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug