RESOLVED FIXED 62711
[EFL][WK2] Add missing functions of EFL port's PageClientImpl 
https://bugs.webkit.org/show_bug.cgi?id=62711
Summary [EFL][WK2] Add missing functions of EFL port's PageClientImpl
Eunmi Lee
Reported 2011-06-15 03:16:12 PDT
I've added missing functions of EFL port's PageClientImpl.cpp. There are 3 functions which is added in the latest PageClient.h. +IntPoint PageClientImpl::screenToWindow(const IntPoint&) +void PageClientImpl::enterAcceleratedCompositingMode(const LayerTreeContext&) +void PageClientImpl::exitAcceleratedCompositingMode()
Attachments
Patch (3.21 KB, patch)
2011-06-15 03:19 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Patch (3.21 KB, patch)
2011-06-15 19:49 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2011-06-15 03:19:35 PDT
Created attachment 97266 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-06-15 03:22:46 PDT
Comment on attachment 97266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170 > +IntPoint PageClientImpl::screenToWindow(const IntPoint&) > +{ > + notImplemented(); > + return IntPoint(); > +} Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0
Eunmi Lee
Comment 3 2011-06-15 19:49:24 PDT
Created attachment 97391 [details] Patch
Eunmi Lee
Comment 4 2011-06-15 19:50:16 PDT
(In reply to comment #2) > (From update of attachment 97266 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review > > > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170 > > +IntPoint PageClientImpl::screenToWindow(const IntPoint&) > > +{ > > + notImplemented(); > > + return IntPoint(); > > +} > > Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0 OK, I've changed to return the given point :)
Gyuyoung Kim
Comment 5 2011-06-15 21:46:49 PDT
LGTM.
Leandro Pereira
Comment 6 2011-06-16 06:54:40 PDT
(In reply to comment #4) > > OK, I've changed to return the given point :) > Looks like you've sent the old patch again :)
Eunmi Lee
Comment 7 2011-06-16 17:40:11 PDT
(In reply to comment #6) > (In reply to comment #4) > > > > OK, I've changed to return the given point :) > > > > Looks like you've sent the old patch again :) Oh, I changed as follows :) -169 return IntPoint() +169 return point;
Leandro Pereira
Comment 8 2011-06-17 08:17:23 PDT
(In reply to comment #7) > > > > Looks like you've sent the old patch again :) > > Oh, I changed as follows :) > -169 return IntPoint() > +169 return point; Oops, missed that :)
WebKit Review Bot
Comment 9 2011-06-18 20:43:00 PDT
Comment on attachment 97391 [details] Patch Clearing flags on attachment: 97391 Committed r89210: <http://trac.webkit.org/changeset/89210>
WebKit Review Bot
Comment 10 2011-06-18 20:43:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.