RESOLVED CONFIGURATION CHANGED60828
Mismatched feature guards for WebChromeClient::fullScreenRendererChanged in WebKit/mac 
https://bugs.webkit.org/show_bug.cgi?id=60828
Summary Mismatched feature guards for WebChromeClient::fullScreenRendererChanged in W...
mitz
Reported 2011-05-13 21:56:54 PDT
The implementation of WebChromeClient::fullScreenRendererChanged() is guarded by #if ENABLE(FULLSCREEN_API) in WebChromeClient.mm, but the declaration in WebChromeClient.h is (incorrectly, I think) guarded by #if ENABLE(VIDEO).
Attachments
Add attachment proposed patch, testcase, etc.
Frédéric Wang Nélar
Comment 1 2026-10-09 07:03:06 PDT
I checked https://searchfox.org/wubkat/source/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h https://searchfox.org/wubkat/source/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp and fullScreenRendererChanged is no longer a thing. The other "fullscreen" matches seem to correctly use VIDEO_PRESENTATION_MODE and FULLSCREEN_API guards.
Note You need to log in before you can comment on or make changes to this bug.