RESOLVED FIXED 60257
build-webkit --minimal build is broken because of r84789 
https://bugs.webkit.org/show_bug.cgi?id=60257
Summary build-webkit --minimal build is broken because of r84789
Bharathwaaj
Reported 2011-05-05 01:29:12 PDT
Compilation error when building with the following command. Tools/Scripts/build-webkit --gtk --no-svg --no-svg-animation --no-svg-as-image --no-svg-dom-objc-bindings --no-svg-fonts --no-svg-foreign-object --no-svg-use --disable-optimizations
Attachments
Patch (5.19 KB, patch)
2011-05-05 02:11 PDT, Bharathwaaj 		no flags
DetailsFormatted DiffDiff
Patch (5.19 KB, patch)
2011-05-05 02:18 PDT, Bharathwaaj 		no flags
DetailsFormatted DiffDiff
Patch addressing only the issue (1.92 KB, patch)
2011-05-05 03:30 PDT, Bharathwaaj 		no flags
DetailsFormatted DiffDiff
Fix minimal build (2.27 KB, patch)
2011-05-05 06:41 PDT, Bharathwaaj 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Bharathwaaj
Comment 1 2011-05-05 02:11:55 PDT
Created attachment 92392 [details] Patch Gaurd with appropriate enable macros.
WebKit Review Bot
Comment 2 2011-05-05 02:14:39 PDT
Attachment 92392 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Bharathwaaj
Comment 3 2011-05-05 02:18:17 PDT
Created attachment 92394 [details] Patch Removed tabs.
Bharathwaaj
Comment 4 2011-05-05 03:30:40 PDT
Created attachment 92400 [details] Patch addressing only the issue This patch removes the reindentation done in previous patches as reviewed by zecke in irc.
Bharathwaaj
Comment 5 2011-05-05 06:41:51 PDT
Created attachment 92409 [details] Fix minimal build Addressed review comments provided by zecke in irc.
Holger Freyther
Comment 6 2011-05-05 06:47:03 PDT
Comment on attachment 92409 [details] Fix minimal build This appears to be the minimal fix for --minimal. With BLOB/FILESYSTEM there is already the case for having #if ENABLE() guards for the JS exceptions.
WebKit Commit Bot
Comment 7 2011-05-05 12:20:31 PDT
The commit-queue encountered the following flaky tests while processing attachment 92409 [details]: java/lc3/JSNumber/ToChar-002-n.html bug 60288 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2011-05-05 12:21:49 PDT
Comment on attachment 92409 [details] Fix minimal build Clearing flags on attachment: 92409 Committed r85868: <http://trac.webkit.org/changeset/85868>
WebKit Commit Bot
Comment 9 2011-05-05 12:21:54 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 10 2011-05-10 13:33:09 PDT
Revision r85868 cherry-picked into qtwebkit-2.2 with commit 093ccfe <http://gitorious.org/webkit/qtwebkit/commit/093ccfe>
Note You need to log in before you can comment on or make changes to this bug.