WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55387
Chromium gypi file should include Java bridge files from WebCore/bridge
https://bugs.webkit.org/show_bug.cgi?id=55387
Summary
Chromium gypi file should include Java bridge files from WebCore/bridge
Steve Block
Reported
2011-02-28 09:51:07 PST
Chromium gypi file should include Java bridge files from WebCore/bridge
Attachments
Patch
(2.40 KB, patch)
2011-02-28 09:57 PST
,
Steve Block
no flags
Details
Formatted Diff
Diff
Patch
(2.39 KB, patch)
2011-03-01 04:37 PST
,
Steve Block
no flags
Details
Formatted Diff
Diff
Patch
(2.39 KB, patch)
2011-03-01 06:43 PST
,
Steve Block
jorlow
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Steve Block
Comment 1
2011-02-28 09:57:40 PST
Created
attachment 84076
[details]
Patch
Steve Block
Comment 2
2011-02-28 09:58:16 PST
Comment on
attachment 84076
[details]
Patch Do not land until dependencies have landed.
WebKit Review Bot
Comment 3
2011-02-28 10:19:53 PST
Attachment 84076
[details]
did not build on chromium: Build output:
http://queues.webkit.org/results/8071358
Dimitri Glazkov (Google)
Comment 4
2011-02-28 10:21:21 PST
Comment on
attachment 84076
[details]
Patch Chromium is barfing. Can haz exludes?
Steve Block
Comment 5
2011-02-28 10:26:25 PST
This should build fine once the dependencies are in. Will run it by the commit queue again once that's the case.
Adam Barth
Comment 6
2011-02-28 10:58:48 PST
Are we planning to use these files in all configurations of Chromium? Perhaps we should exclude them conditionally.
WebKit Review Bot
Comment 7
2011-02-28 13:15:33 PST
Attachment 84076
[details]
did not build on chromium: Build output:
http://queues.webkit.org/results/8071402
Steve Block
Comment 8
2011-03-01 04:37:28 PST
Created
attachment 84210
[details]
Patch
WebKit Review Bot
Comment 9
2011-03-01 04:55:31 PST
Attachment 84210
[details]
did not build on chromium: Build output:
http://queues.webkit.org/results/8072627
Steve Block
Comment 10
2011-03-01 04:59:50 PST
Comment on
attachment 84210
[details]
Patch The build fails due to the JAVA_BRIDGE guards being incomplete. Filed
Bug 55459
.
> Are we planning to use these files in all configurations of Chromium?
The gypi file should list all WebCore files, so I think it makes sense to add these, once they build OK.
Steve Block
Comment 11
2011-03-01 06:43:15 PST
Created
attachment 84224
[details]
Patch
Jeremy Orlow
Comment 12
2011-03-01 09:00:48 PST
Comment on
attachment 84224
[details]
Patch r=me
WebKit Commit Bot
Comment 13
2011-03-01 14:51:16 PST
Comment on
attachment 84224
[details]
Patch Rejecting
attachment 84224
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 1 Last 500 characters of output: rks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output:
http://queues.webkit.org/results/8071723
Steve Block
Comment 14
2011-03-01 14:56:42 PST
Looks like commit queue flakiness. Will land manually.
Steve Block
Comment 15
2011-03-01 14:56:55 PST
Committed
r80045
: <
http://trac.webkit.org/changeset/80045
>
Eric Seidel (no email)
Comment 16
2011-03-01 17:10:57 PST
(In reply to
comment #14
)
> Looks like commit queue flakiness. > > Will land manually.
Looks like our AppEngine instance went down for a second. :) We dont' handle that case very well.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug