RESOLVED FIXED 53949
ImageDecoder.h hardcodes RGBA byteorder on Skia 
https://bugs.webkit.org/show_bug.cgi?id=53949
Summary ImageDecoder.h hardcodes RGBA byteorder on Skia
George Wright
Reported 2011-02-07 14:56:34 PST
At the moment the setRGBA function in ImageDecoder.h hard codes the colour byte order: *dest = (a << 24 | r << 16 | g << 8 | b); In Skia's case this should use Skia's helper function SkPackARGB32.
Attachments
Use SkPackARGB32 in Skia's case (1.83 KB, patch)
2011-02-07 15:00 PST, George Wright 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
George Wright
Comment 1 2011-02-07 15:00:13 PST
Created attachment 81531 [details] Use SkPackARGB32 in Skia's case Patch to use SkPackARGB32 in Skia's case.
Eric Seidel (no email)
Comment 2 2011-02-07 15:07:11 PST
I'm confused why this needs to be in a shared file.
Peter Kasting
Comment 3 2011-02-07 15:09:41 PST
This looks OK to me. (In reply to comment #2) > I'm confused why this needs to be in a shared file. It needs to be inlined into all the decoders.
Adam Barth
Comment 4 2011-02-07 16:00:12 PST
Comment on attachment 81531 [details] Use SkPackARGB32 in Skia's case This change is fine, but it illustrates some of the design problems with this class.
Patrick R. Gansterer
Comment 5 2011-02-08 07:44:15 PST
Comment on attachment 81531 [details] Use SkPackARGB32 in Skia's case cq+ as requested by gw280 on IRC
WebKit Commit Bot
Comment 6 2011-02-08 09:15:52 PST
The commit-queue encountered the following flaky tests while processing attachment 81531 [details]: http/tests/websocket/tests/error-detect.html bug 54012 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-02-08 09:17:04 PST
Comment on attachment 81531 [details] Use SkPackARGB32 in Skia's case Clearing flags on attachment: 81531 Committed r77946: <http://trac.webkit.org/changeset/77946>
WebKit Commit Bot
Comment 8 2011-02-08 09:17:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.