RESOLVED FIXED 53289
DOM: Move DocumentOrderedMap from Document into separate files 
https://bugs.webkit.org/show_bug.cgi?id=53289
Summary DOM: Move DocumentOrderedMap from Document into separate files
Roland Steiner
Reported 2011-01-28 01:05:58 PST
DocumentOrderedMap currently is a nested class inside Document. To cut down on the size of Document.h/.cpp, as well as allow further refactoring, esp. for shadow DOM, it would be better if this was made a separate class and moved into its own files.
Attachments
Patch (23.19 KB, patch)
2011-01-28 02:24 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Patch, try again (25.44 KB, patch)
2011-01-30 21:45 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Patch, try de third (26.71 KB, patch)
2011-01-31 01:02 PST, Roland Steiner 		dglazkov: review+
dglazkov: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-01-28 02:24:28 PST
Created attachment 80432 [details] Patch
Build Bot
Comment 2 2011-01-28 03:19:08 PST
Attachment 80432 [details] did not build on win: Build output: http://queues.webkit.org/results/7560379
Early Warning System Bot
Comment 3 2011-01-28 03:23:42 PST
Attachment 80432 [details] did not build on qt: Build output: http://queues.webkit.org/results/7657049
Dimitri Glazkov (Google)
Comment 4 2011-01-28 08:50:42 PST
Comment on attachment 80432 [details] Patch This is great! Please update all build systems to ensure no bot breakages.
Roland Steiner
Comment 5 2011-01-30 21:45:10 PST
Created attachment 80617 [details] Patch, try again
Build Bot
Comment 6 2011-01-30 22:43:56 PST
Attachment 80617 [details] did not build on win: Build output: http://queues.webkit.org/results/7680166
Early Warning System Bot
Comment 7 2011-01-31 00:15:09 PST
Attachment 80617 [details] did not build on qt: Build output: http://queues.webkit.org/results/7567944
Roland Steiner
Comment 8 2011-01-31 01:02:26 PST
Created attachment 80623 [details] Patch, try de third
Roland Steiner
Comment 9 2011-01-31 02:08:16 PST
Hmmm... any idea what issues 'gtk' and 'mac' have patching the .vcproj file? 'win' seems to like it... @_@?
Dimitri Glazkov (Google)
Comment 10 2011-01-31 08:54:18 PST
Comment on attachment 80623 [details] Patch, try de third View in context: https://bugs.webkit.org/attachment.cgi?id=80623&action=review Changes to vcproj suck. I don't know why, but I get purples on them too. But your project changes look good, except for android. Let's see if this works. > Source/WebCore/ChangeLog:13 > + * GNUMakefile.am: I think you're going to break Android build.
Roland Steiner
Comment 11 2011-02-01 01:32:44 PST
Reverted r77229 for reason: revert mysterious build breakage Committed r77231: <http://trac.webkit.org/changeset/77231>
Roland Steiner
Comment 12 2011-02-01 05:23:09 PST
committed in r77239, with additional entries in Android.mk and CMakeLists.txt, so as to hopefully not-break Android and EFL.
Note You need to log in before you can comment on or make changes to this bug.