RESOLVED FIXED 51163
Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests 
https://bugs.webkit.org/show_bug.cgi?id=51163
Summary Settings::editingBehaviorType() incorrectly returns mac for the gtk build whe...
Benjamin (Ben) Kalman
Reported 2010-12-15 21:04:45 PST
As in summary, Settings::editingBehaviorType() incorrectly returns mac (EditingMacBehavior) for gtk *when running tests*. When running the gtk launcher (i.e. *not* in a test), it correctly returns unix (EditingUnixBehavior). This is causing a confusing discrepancy in reported test results versus actual behavior, in at least editing/selection/extend-selection-home-end.html. Note how the mac and gtk results are the same, when actually the gtk results should the same as the win ones (and this is caused by the check in SelectionController::positionForPlatform).
Attachments
patch v1 (committed r74269, r=mrobinson) (17.10 KB, patch)
2010-12-16 19:24 PST, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 2 2010-12-16 06:23:13 PST
I will look at this today.
Antonio Gomes
Comment 3 2010-12-16 19:24:41 PST
Created attachment 76841 [details] patch v1 (committed r74269, r=mrobinson) 1) Make GTK+ reset its editing behavior to UNIX (default) instead of Mac in DumpRenderTree::resetDefaultsToConsistentValues 2) Removes gtk and win expectation files for editing/selection/extend-selection-home-end.html since they are equal to the cross platform result.
Ryosuke Niwa
Comment 4 2010-12-16 19:32:21 PST
Comment on attachment 76841 [details] patch v1 (committed r74269, r=mrobinson) LGTM. Thanks for fixing this bug :)
Antonio Gomes
Comment 5 2010-12-17 08:19:36 PST
Comment on attachment 76841 [details] patch v1 (committed r74269, r=mrobinson) Clearing flags on attachment: 76841 Committed r74269: <http://trac.webkit.org/changeset/74269>
WebKit Review Bot
Comment 6 2010-12-17 08:55:44 PST
http://trac.webkit.org/changeset/74269 might have broken GTK Linux 64-bit Debug
Antonio Gomes
Comment 7 2010-12-17 09:14:23 PST
(In reply to comment #6) > http://trac.webkit.org/changeset/74269 might have broken GTK Linux 64-bit Debug Fixed in http://trac.webkit.org/changeset/74273 with the test rebasilined, and filed bug 51261 for the proper fix.
Note You need to log in before you can comment on or make changes to this bug.