RESOLVED DUPLICATE of bug 41441 48991
[chromium] when creating a window, pass the respective url request along 
https://bugs.webkit.org/show_bug.cgi?id=48991
Summary [chromium] when creating a window, pass the respective url request along
jochen
Reported 2010-11-04 06:53:21 PDT
[chromium] when creating a window, pass the respective url request along
Attachments
Patch (3.00 KB, patch)
2010-11-04 06:54 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (5.44 KB, patch)
2010-11-04 07:01 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2010-11-04 06:54:27 PDT
Created attachment 72935 [details] Patch
jochen
Comment 2 2010-11-04 07:01:18 PDT
Created attachment 72936 [details] Patch
jochen
Comment 3 2010-11-04 07:02:55 PDT
passing the request allows the embedder to derive information about what's going to happen with the new window. chromium side is here: http://codereview.chromium.org/4458002/show
Darin Fisher (:fishd, Google)
Comment 4 2010-11-04 12:34:04 PDT
I'm slightly concerned about passing the WebURLRequest to createView since it may give the false impression that createView is suppose to call loadRequest. Also, this bug seems like a duplicate of https://bugs.webkit.org/show_bug.cgi?id=41441. The patch in that bug is more involved.
jochen
Comment 5 2010-11-05 03:24:33 PDT
*** This bug has been marked as a duplicate of bug 41441 ***
Eric Seidel (no email)
Comment 6 2010-11-07 23:41:02 PST
Comment on attachment 72936 [details] Patch Cleared review? from attachment 72936 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.