RESOLVED WONTFIX 31274
Prepended $$PWD to GENERATED_SOURCES_DIR 
https://bugs.webkit.org/show_bug.cgi?id=31274
Summary Prepended $$PWD to GENERATED_SOURCES_DIR
Norbert Leser
Reported 2009-11-09 13:13:23 PST
Created attachment 42791 [details] Patch for USERINCLUDE paths for symbian Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro. Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore), and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).
Attachments
Patch for USERINCLUDE paths for symbian (1.20 KB, patch)
2009-11-09 13:13 PST, Norbert Leser 		no flags
DetailsFormatted DiffDiff
Patch for prepending PWD to GENERATED_SOURCES_DIR (1.20 KB, patch)
2009-11-09 13:16 PST, Norbert Leser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Norbert Leser
Comment 1 2009-11-09 13:16:39 PST
Created attachment 42793 [details] Patch for prepending PWD to GENERATED_SOURCES_DIR Corrected description of previous patch.
WebKit Commit Bot
Comment 2 2009-11-09 14:35:06 PST
Comment on attachment 42793 [details] Patch for prepending PWD to GENERATED_SOURCES_DIR Clearing flags on attachment: 42793 Committed r50695: <http://trac.webkit.org/changeset/50695>
WebKit Commit Bot
Comment 3 2009-11-09 14:35:12 PST
All reviewed patches have been landed. Closing bug.
Laszlo Gombos
Comment 4 2009-11-09 17:47:57 PST
Bug needs to be REOPENED as the landed fix had to be reverted because it broke clean build. Here is the error (breaks when it tries to compile standalone JSC). ../../../JavaScriptCore/pcre/pcre_tables.cpp:72:24: error: chartables.c: No such file or directory make[1]: *** [obj/debug/pcre_tables.o] Error 1 make: *** [sub-JavaScriptCore-jsc-pro-make_default-ordered] Error 2 For some reason I can not change the status to REOPEN.
Eric Seidel (no email)
Comment 5 2009-11-09 17:51:59 PST
You look to have 3 separate bugzilla accounts. :( I've added edit bugs permissions to a second one.
Eric Seidel (no email)
Comment 6 2009-11-09 17:52:46 PST
Starting a rollout per laszlo's request.
Eric Seidel (no email)
Comment 7 2009-11-09 17:55:15 PST
Nevermind. Laszlo already rolled it out in r50701. Please make sure you update the bug with the revision number if you do a rollout.
Norbert Leser
Comment 8 2009-11-09 17:57:19 PST
Sorry, to hear that it broke another build. Laszlo, can you specify what your build target was so I can try to reproduce it and work on a potential fix.
Laszlo Gombos
Comment 9 2009-11-09 18:36:41 PST
(In reply to comment #8) > Sorry, to hear that it broke another build. Laszlo, can you specify what your > build target was so I can try to reproduce it and work on a potential fix. I saw the build break first on Mac (build-webkit --qt --no-svg --debug) and reproduced on Linux as well (build-webkit --qt --no--svg --release). QtWebKit library builds Ok, but standalone jsc failed.
Laszlo Gombos
Comment 10 2010-02-22 15:27:07 PST
Does not seems to be an issue any more (especially after pre-generation step).
Note You need to log in before you can comment on or make changes to this bug.