WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
276884
Remove Quirk 'shouldDisableElementFullscreenQuirk' from twitter.com
https://bugs.webkit.org/show_bug.cgi?id=276884
Summary
Remove Quirk 'shouldDisableElementFullscreenQuirk' from twitter.com
Ahmad Saleem
Reported
2024-07-22 08:43:11 PDT
See
https://searchfox.org/wubkat/rev/38fb2ecadd89df8d6d7114cc2b030188d744aeb0/Source/WebCore/page/Quirks.cpp#415
It was added by following commit:
https://commits.webkit.org/274117@main
in
bug 268634
, where the precursor was the 'media controls' show up as small when in fullscreen. 1. Compile WebKit Opensource with removal of quirk 2. Go to test page via iOS simulator -
https://ftw.usatoday.com/2024/01/lamar-jackson-cj-stroud-micd-up-ravens-texans
2. See if the embedded video on fullscreen does not show any issue (small icons etc.) Expected result: - No small icon issue
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-07-29 08:44:20 PDT
<
rdar://problem/132725236
>
Frédéric Wang Nélar
Comment 2
2026-10-15 08:24:48 PDT
This was actually added in
https://commits.webkit.org/273519@main
Now it seems this is handled by a yaml file,
https://searchfox.org/wubkat/rev/19ca701af784c4a231699ba99f5af78f514c4456/Source/WebCore/page/QuirkBehaviors.yaml#474
But I don't see how to know to which domain this is actually applying.
Frédéric Wang Nélar
Comment 3
2026-10-15 08:34:54 PDT
It seems it's only enabled here:
https://searchfox.org/wubkat/rev/19ca701af784c4a231699ba99f5af78f514c4456/Source/WebCore/page/Quirks.cpp#1306
https://searchfox.org/wubkat/source/Source/WebCore/page/QuirkTable.cpp
does not seem to contain any case for shouldDisableElementFullscreenQuirk
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug