WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257428
[popover] Refactor all popover showing checks
https://bugs.webkit.org/show_bug.cgi?id=257428
Summary
[popover] Refactor all popover showing checks
Tim Nguyen (:ntim)
Reported
2023-05-27 14:04:30 PDT
popoverData() && popoverData()->visibilityState() == PopoverVisibilityState::Showing is a very common check across the codebase, we should have a helper function (isShowingPopover / isOpenPopover?)
Attachments
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
2023-05-30 09:30:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14487
EWS
Comment 2
2023-05-30 12:57:07 PDT
Committed
264693@main
(415cdc82121c): <
https://commits.webkit.org/264693@main
> Reviewed commits have been landed. Closing PR #14487 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-05-30 12:58:18 PDT
<
rdar://problem/110020705
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug