WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
241489
Track SVG renderer updates using a NodeFlag instead of on Style::Update
https://bugs.webkit.org/show_bug.cgi?id=241489
Summary
Track SVG renderer updates using a NodeFlag instead of on Style::Update
Cameron McCormack (:heycam)
Reported
2022-06-09 14:00:32 PDT
SVG renderer updates are currently tracked as a kind of Style::Update change. When a page is updating attributes on many SVG elements, but is not making changes that require a restyle on those elements, we can spend a lot of time hashing to store and look up the Style::Update associated with an element. We could track the "SVG renderer update is needed" state using a Node flag instead, but continue using the Style::Update mechanism for root tracking, to reduce the overhead.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-06-09 14:00:54 PDT
<
rdar://problem/94756741
>
Cameron McCormack (:heycam)
Comment 2
2022-06-09 14:20:24 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1430
Cameron McCormack (:heycam)
Comment 3
2022-06-13 22:01:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1492
Cameron McCormack (:heycam)
Comment 4
2022-06-13 22:04:38 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1493
EWS
Comment 5
2022-06-14 15:00:42 PDT
Committed
r295539
(
251544@main
): <
https://commits.webkit.org/251544@main
> Reviewed commits have been landed. Closing PR #1430 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug