WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
233099
Modal dialogs should make the root element unfocusable
https://bugs.webkit.org/show_bug.cgi?id=233099
Summary
Modal dialogs should make the root element unfocusable
Tim Nguyen (:ntim)
Reported
2021-11-14 09:42:40 PST
From
https://html.spec.whatwg.org/multipage/interaction.html#inert
,
> A Document document is blocked by a modal dialog subject if subject is > the topmost dialog element in document's top layer. While document is > so blocked, every node that is connected to document, with the > exception of the subject element and its shadow-including descendants, > must be marked inert.
RenderStyle::effectiveInert() already matches this definition, Node::deprecatedIsInert() does not. Main reason for the removed check was to prevent the whole document from being inert to hit-testing, but with the RenderStyle approach, we instead override effectiveInert to false for the modal dialog. Removing this check for focus is absolutely fine however, since focusability isn't inherited. Tests added by this Chromium WPT:
https://github.com/web-platform-tests/wpt/commit/0457111e7109ec3d9e575aa421b96d8c36ce2ae8
Attachments
Patch
(8.47 KB, patch)
2021-11-14 09:57 PST
,
Tim Nguyen (:ntim)
no flags
Details
Formatted Diff
Diff
Patch
(8.36 KB, patch)
2021-11-14 09:58 PST
,
Tim Nguyen (:ntim)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1
2021-11-14 09:57:01 PST
Created
attachment 444178
[details]
Patch
EWS Watchlist
Comment 2
2021-11-14 09:57:56 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see
https://trac.webkit.org/wiki/WPTExportProcess
Tim Nguyen (:ntim)
Comment 3
2021-11-14 09:58:26 PST
Created
attachment 444179
[details]
Patch
EWS
Comment 4
2021-11-14 10:47:39 PST
Committed
r285791
(
244235@main
): <
https://commits.webkit.org/244235@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 444179
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-11-14 10:48:21 PST
<
rdar://problem/85391533
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug