WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
225469
REGRESSION (
r277071
): imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is failing
https://bugs.webkit.org/show_bug.cgi?id=225469
Summary
REGRESSION (r277071): imported/w3c/web-platform-tests/css/mediaqueries/test_m...
Truitt Savell
Reported
2021-05-06 11:03:09 PDT
The changes in
https://trac.webkit.org/changeset/277071/webkit
broke imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html on Mac release Macmini8,1 machines Diff:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r277093%20(2369)/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-diff.txt
history:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fmediaqueries%2Ftest_media_queries.html
Attachments
Patch
(90.68 KB, patch)
2021-05-06 23:09 PDT
,
Tim Nguyen (:ntim)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-05-06 11:03:30 PDT
<
rdar://problem/77616012
>
Sam Sneddon [:gsnedders]
Comment 2
2021-05-06 13:13:12 PDT
The subtest name seems to vary here since a recent upstream change to the test by Emilio; filed this upstream at
https://github.com/web-platform-tests/wpt/issues/28879
and hopefully Emilio fixes this soon.
Sam Sneddon [:gsnedders]
Comment 3
2021-05-06 15:16:27 PDT
https://github.com/web-platform-tests/wpt/commit/17bf9de651f9f77d8f4f32aeb30da6128b046469
has landed upstream, which stops the subtest names from changing all the time. Tim, can you reimport the media queries tests following this?
Tim Nguyen (:ntim)
Comment 4
2021-05-06 23:09:55 PDT
Created
attachment 427974
[details]
Patch
EWS Watchlist
Comment 5
2021-05-06 23:10:42 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see
https://trac.webkit.org/wiki/WPTExportProcess
Tim Nguyen (:ntim)
Comment 6
2021-05-06 23:11:05 PDT
Thank you Sam!
Tim Nguyen (:ntim)
Comment 7
2021-05-06 23:11:26 PDT
Committed
r277160
(
237446@main
): <
https://commits.webkit.org/237446@main
>
Sam Sneddon [:gsnedders]
Comment 8
2021-05-07 06:51:10 PDT
Alas, this still looks bad, albeit now just due to
bug 161693
.
Truitt Savell
Comment 9
2021-05-07 11:09:17 PDT
Marked this test as failing with
https://trac.webkit.org/changeset/277181/webkit
Ryan Haddad
Comment 10
2021-05-11 12:03:14 PDT
Marked as failing for iOS with
r277335
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug