RESOLVED CONFIGURATION CHANGED 216182
Remove stale reference to RuntimeEnabledFeatures 
https://bugs.webkit.org/show_bug.cgi?id=216182
Summary Remove stale reference to RuntimeEnabledFeatures
Sam Weinig
Reported 2020-09-04 09:29:40 PDT
Use of WebCore::RuntimeEnabledFeatures is almost always wrong as it is a global singleton that can be set by multiple different API layer preferences objects. Over the years, it has become convenient, as it "works" for settings that need to be accessed in non-page accessible places, but in reality, those are likely threading issues waiting to happen or layering violations due to use of RuntimeEnabledFeatures from the platform directory. See related, 215962 (Obsolete DeprecatedGlobalSettings)
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-04 09:31:20 PDT
The biggest thing to do here is likely adding a mechanism to extend WebCore::Settings (as generated from Settings.yaml) or a subset thereof, to work with Workers.
Radar WebKit Bug Importer
Comment 2 2020-09-11 09:30:13 PDT
<rdar://problem/68714643>
Ahmad Saleem
Comment 3 2023-09-08 16:02:38 PDT
Only able to find one incorrect include 'RuntimeEnabledFeatures' (using this search): https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#35 and https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#100 It also got consolidated here: https://github.com/WebKit/WebKit/commit/5ddb4127ac4e4a104338422e546a1cdc7b698769 @Tim - you reviewed above commit, do we need this bug to remain open? @Alexey - any help if Tim is not right contact?
Alexey Proskuryakov
Comment 4 2023-09-08 18:48:37 PDT
CC'ing some folks who worked on feature flags recently.
Tim Nguyen (:ntim)
Comment 5 2023-11-06 01:57:17 PST
Yeah RuntimeEnabledFeatures was removed. I'm going to repurpose this to be about removing the stale include Ahmad found.
Alexsander Borges Damaceno
Comment 6 2025-05-11 23:35:56 PDT
Pull request: https://github.com/WebKit/WebKit/pull/45233
Sam Weinig
Comment 7 2025-05-14 10:07:10 PDT
I removed this file (along with the whole DecoderTest directory) in https://bugs.webkit.org/show_bug.cgi?id=292936 / 593ffb9. We can close this.
Note You need to log in before you can comment on or make changes to this bug.