RESOLVED FIXED 215624
ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext 
https://bugs.webkit.org/show_bug.cgi?id=215624
Summary ScriptProcessNode should only run script asynchronously if the audio context ...
Chris Dumez
Reported 2020-08-18 13:50:14 PDT
ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext. If the context is an OfflineAudioContext, then it should pause processing until the script has finished execution. This aligns our behavior with Blink and helps us pass more WPT tests.
Attachments
Patch (9.08 KB, patch)
2020-08-18 14:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.15 KB, patch)
2020-08-18 14:56 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-18 14:09:07 PDT
Created attachment 406808 [details] Patch
Eric Carlson
Comment 2 2020-08-18 14:30:52 PDT
Comment on attachment 406808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406808&action=review > Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:214 > + // De-reference to match the ref() call in process(). Nit: it is a little odd to have this comment only on the second `deref()`
Chris Dumez
Comment 3 2020-08-18 14:56:21 PDT
Created attachment 406816 [details] Patch
EWS
Comment 4 2020-08-18 15:51:23 PDT
Committed r265836: <https://trac.webkit.org/changeset/265836> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406816 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-18 15:52:16 PDT
<rdar://problem/67358588>
Note You need to log in before you can comment on or make changes to this bug.