WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
206174
Calculate new PropertyList features during parsing
https://bugs.webkit.org/show_bug.cgi?id=206174
Summary
Calculate new PropertyList features during parsing
Caitlin Potter (:caitp)
Reported
2020-01-13 06:28:18 PST
Minor optimization requested in
https://bugs.webkit.org/attachment.cgi?id=387361&action=review#line1046
It might be worthwhile to pre-calculate the result of 'shouldCreateLexicalSCopeForClass' and 'hasInstanceFields' during parsing, or otherwise cache the value after the first calculation. Reasons for not doing this: it makes things like AST rewriting a bit more awkward and error prone (but, AST rewriting is not as common in JSC as in v8), and the hit from walking property list to determine these features might not be significant as they are not believed to be invoked frequently. It warrants some investigation.
Attachments
Add attachment
proposed patch, testcase, etc.
Caitlin Potter (:caitp)
Comment 1
2020-01-13 06:30:21 PST
If this gets taken on, I think it qualifies as a good first bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug