WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205122
Python 3: Add support in webkitpy.performance_tests
https://bugs.webkit.org/show_bug.cgi?id=205122
Summary
Python 3: Add support in webkitpy.performance_tests
Jonathan Bedard
Reported
2019-12-11 09:50:58 PST
Make webkitpy.performance_tests Python 3 compatible.
Attachments
Patch
(14.53 KB, patch)
2019-12-11 09:53 PST
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch for landing
(14.64 KB, patch)
2019-12-11 13:01 PST
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2019-12-11 09:53:00 PST
Created
attachment 385404
[details]
Patch
Stephanie Lewis
Comment 2
2019-12-11 12:43:19 PST
Comment on
attachment 385404
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=385404&action=review
> Tools/Scripts/webkitpy/performance_tests/perftest.py:171 > + _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {} {}'.format(
When there that many {} I prefer keywords. Makes it easier to read
Jonathan Bedard
Comment 3
2019-12-11 12:59:55 PST
Comment on
attachment 385404
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=385404&action=review
>> Tools/Scripts/webkitpy/performance_tests/perftest.py:171 >> + _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {} {}'.format( > > When there that many {} I prefer keywords. Makes it easier to read
Good idea, makes this much more reasonable.
Jonathan Bedard
Comment 4
2019-12-11 13:01:16 PST
Created
attachment 385426
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2019-12-11 13:46:03 PST
Comment on
attachment 385426
[details]
Patch for landing Clearing flags on attachment: 385426 Committed
r253392
: <
https://trac.webkit.org/changeset/253392
>
WebKit Commit Bot
Comment 6
2019-12-11 13:46:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-12-11 13:47:18 PST
<
rdar://problem/57851823
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug