204629 – Remove own toString from NativeError prototype

RESOLVED FIXED 204629

Remove own toString from NativeError prototype

https://bugs.webkit.org/show_bug.cgi?id=204629

Summary Remove own toString from NativeError prototype

Reported 2019-11-26 14:42:39 PST

Remove own toString from NativeError prototype

Attachments
Patch (6.88 KB, patch) 2019-11-26 14:43 PST, me	no flags	Details Formatted Diff Diff
Patch (6.86 KB, patch) 2019-11-26 15:04 PST, me	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (4.36 MB, application/zip) 2019-11-26 16:25 PST, EWS Watchlist	no flags	Details
Patch (6.67 KB, patch) 2019-11-26 22:05 PST, me	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (14.94 MB, application/zip) 2019-11-27 02:18 PST, EWS Watchlist	no flags	Details
Patch (6.89 KB, patch) 2019-11-27 08:36 PST, me	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (14.80 MB, application/zip) 2019-11-27 10:19 PST, EWS Watchlist	no flags	Details
Patch (9.43 KB, patch) 2019-11-28 19:28 PST, me	no flags	Details Formatted Diff Diff
Patch (129.31 KB, patch) 2019-11-29 14:04 PST, me	no flags	Details Formatted Diff Diff
Patch (129.21 KB, patch) 2020-01-19 15:45 PST, me	no flags	Details Formatted Diff Diff
patch (130.26 KB, patch) 2020-01-20 14:34 PST, me	no flags	Details Formatted Diff Diff
Patch (130.26 KB, patch) 2020-01-20 14:40 PST, me	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Comment 1 2019-11-26 14:43:59 PST

Created attachment 384381 [details] Patch

Comment 2 2019-11-26 15:04:50 PST

Created attachment 384383 [details] Patch

Comment 3 2019-11-26 15:33:25 PST

It seems with the current patch, Error.prototype.toString isn't being created anymore. I admittedly have no idea how any of this works, so pointers would be appreciated.

EWS Watchlist

Comment 4 2019-11-26 16:25:32 PST Comment hidden (obsolete)

Comment on attachment 384383 [details] Patch Attachment 384383 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13280265 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 2019-11-26 16:25:34 PST Comment hidden (obsolete)

Created attachment 384385 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 6 2019-11-26 22:05:51 PST

Created attachment 384397 [details] Patch

EWS Watchlist

Comment 7 2019-11-27 02:18:49 PST Comment hidden (obsolete)

Comment on attachment 384397 [details] Patch Attachment 384397 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13280748 New failing tests: http/tests/security/regress-52192.html

EWS Watchlist

Comment 8 2019-11-27 02:18:52 PST Comment hidden (obsolete)

Created attachment 384405 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 9 2019-11-27 08:36:33 PST

Created attachment 384415 [details] Patch

EWS Watchlist

Comment 10 2019-11-27 10:19:43 PST Comment hidden (obsolete)

Comment on attachment 384415 [details] Patch Attachment 384415 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13281401 New failing tests: http/tests/security/regress-52192.html

EWS Watchlist

Comment 11 2019-11-27 10:19:45 PST Comment hidden (obsolete)

Created attachment 384418 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 12 2019-11-28 19:28:32 PST

Created attachment 384476 [details] Patch

Comment 13 2019-11-29 14:04:46 PST

Created attachment 384526 [details] Patch

Ross Kirsling

Comment 14 2019-11-29 14:44:54 PST

Comment on attachment 384526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384526&action=review r=me, though you'll need to regenerate the ChangeLogs. > JSTests/stress/nativeerror-prototype-tostring.js:7 > + if (NativeError.prototype.hasOwnProperty('toString')) { > + throw new Error(`${NativeError.name}.prototype should not have own property 'toString'`); > + } Nit: WK style drops braces for one-line conditionals (https://webkit.org/code-style-guidelines/#braces-one-line). I guess the checker ignores JS stress tests but we ought to align anyway.

Comment 15 2020-01-19 15:45:26 PST

Created attachment 388198 [details] Patch

Darin Adler

Comment 16 2020-01-20 10:26:18 PST

Comment on attachment 388198 [details] Patch Code change looks pretty good. Need to fix the failing tests on EWS before we get this reviewed.

Ross Kirsling

Comment 17 2020-01-20 14:21:04 PST

Comment on attachment 388198 [details] Patch The EWS failure here is just due to auto-trimmed whitespace; just need to undo that and get the regenerated changelogs into the patch. :)

Comment 18 2020-01-20 14:34:29 PST

Created attachment 388258 [details] patch

Comment 19 2020-01-20 14:40:40 PST

Created attachment 388259 [details] Patch

WebKit Commit Bot

Comment 20 2020-01-20 19:47:43 PST

The commit-queue encountered the following flaky tests while processing attachment 388259 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 21 2020-01-20 19:48:24 PST

Comment on attachment 388259 [details] Patch Clearing flags on attachment: 388259 Committed r254842: <https://trac.webkit.org/changeset/254842>

WebKit Commit Bot

Comment 22 2020-01-20 19:48:26 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 23 2020-01-20 19:49:20 PST

<rdar://problem/58747998>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Nobody

Reported

2019-11-26 14:42 PST

Modified

2020-01-20 19:49 PST History

CC List

12 users Show

URL

Keywords InRadar

Depends on

Blocks