WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
203519
Move tracking and computation of timer heap current insertion order to ThreadTimers
https://bugs.webkit.org/show_bug.cgi?id=203519
Summary
Move tracking and computation of timer heap current insertion order to Thread...
Daniel Bates
Reported
2019-10-28 14:19:09 PDT
We track the heap insertion count (a simple counter, which may overflow, each time an entry is inserted) as a means to ensure that timers with the same firing time are ordered by insertion in the heap. Currently this count is a process-wide (i.e. globally unique across all threads). But it doesn't need to be and it increases the rate at which the count can overflow (since multiple threads can increment it). Architecturally it makes more sense for this count to move to per-thread storage.
Attachments
Patch
(3.67 KB, patch)
2019-10-28 14:32 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2019-10-28 14:32:00 PDT
Created
attachment 382109
[details]
Patch
Daniel Bates
Comment 2
2019-10-30 15:15:50 PDT
Comment on
attachment 382109
[details]
Patch Clearing flags on attachment: 382109 Committed
r251810
: <
https://trac.webkit.org/changeset/251810
>
Daniel Bates
Comment 3
2019-10-30 15:15:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2019-10-30 15:16:29 PDT
<
rdar://problem/56760431
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug