RESOLVED FIXED201445
[Win] Add support for MouseEvent.buttons 
https://bugs.webkit.org/show_bug.cgi?id=201445
Summary [Win] Add support for MouseEvent.buttons
Fujii Hironori
Reported 2019-09-03 20:41:47 PDT
Created attachment 377952 [details] test case [Win] Add support for MouseEvent.buttons https://www.w3.org/TR/uievents/#dom-mouseevent-buttons Bug 178214 – [Mac] Add support for MouseEvent.buttons Bug 191481 – REGRESSION(r223264): [GTK] Unable to drag documents on Google Drive
Attachments
test case (734 bytes, text/html)
2019-09-03 20:41 PDT, Fujii Hironori 		no flags
Details
Patch (6.04 KB, patch)
2019-09-03 21:13 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews210 for win-future (7.11 MB, application/zip)
2019-09-03 22:09 PDT, EWS Watchlist 		no flags
Details
Patch (4.53 KB, patch)
2019-09-05 00:29 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-09-03 20:43:24 PDT
another test case: https://jsfiddle.net/fujihiro/vy7hkpLw/10/embedded/result/
Fujii Hironori
Comment 2 2019-09-03 21:13:42 PDT
Created attachment 377954 [details] Patch
Brent Fulgham
Comment 3 2019-09-03 21:21:21 PDT
Comment on attachment 377954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377954&action=review > Source/WebCore/platform/win/PlatformMouseEventWin.cpp:92 > +} Could we put this helper somewhere like GDIUtilities.h?
EWS Watchlist
Comment 4 2019-09-03 22:09:28 PDT
Comment on attachment 377954 [details] Patch Attachment 377954 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12995131 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 5 2019-09-03 22:09:30 PDT
Created attachment 377956 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Brent Fulgham
Comment 6 2019-09-04 09:18:59 PDT
Comment on attachment 377954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377954&action=review > Source/WebCore/platform/win/PlatformMouseEventWin.cpp:121 > + m_button = NoButton; This change seems to break AppleWin (editing and drag/drop operations). Do those tests need to be rebased? Is WebKit relying on behavior that is counter to the spec? The tests that are failing related to editing/selection and dragging. I know that dragging involves mouse moves with the left button held down; I suspect this change breaks those tests because MouseMove (after this change) always has NoButton. I don't think this change is correct.
Fujii Hironori
Comment 7 2019-09-05 00:12:30 PDT
Oh.. Filed: Bug 201496 – MouseEvent.button should be 0 for mousemove events Bug 201497 – WheelEvent should set buttons property properly because it is a subclass of MouseEvent
Fujii Hironori
Comment 8 2019-09-05 00:29:58 PDT
Created attachment 378054 [details] Patch * Addressed the review feedback.
Brent Fulgham
Comment 9 2019-09-05 19:35:12 PDT
Comment on attachment 378054 [details] Patch r=me
Fujii Hironori
Comment 10 2019-09-05 19:40:23 PDT
Comment on attachment 378054 [details] Patch Clearing flags on attachment: 378054 Committed r249560: <https://trac.webkit.org/changeset/249560>
Fujii Hironori
Comment 11 2019-09-05 19:40:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-09-05 19:41:21 PDT
<rdar://problem/55096934>
Note You need to log in before you can comment on or make changes to this bug.