NEW192256
Stop using a global singleton for NetworkCapture::Manager 
https://bugs.webkit.org/show_bug.cgi?id=192256
Summary Stop using a global singleton for NetworkCapture::Manager
Alex Christensen
Reported 2018-11-30 14:29:36 PST
Stop using a global singleton for NetworkCapture::singleton
Attachments
Patch (26.06 KB, patch)
2018-11-30 14:30 PST, Alex Christensen 		cdumez: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (1.36 MB, application/zip)
2018-11-30 15:39 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (226.64 MB, application/zip)
2018-12-01 02:53 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-11-30 14:30:29 PST
Created attachment 356240 [details] Patch
Chris Dumez
Comment 2 2018-11-30 14:44:12 PST
Comment on attachment 356240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356240&action=review > Source/WebKit/NetworkProcess/capture/NetworkCaptureRecorder.h:46 > + Recorder(Manager& manager) explicit ? > Source/WebKit/NetworkProcess/capture/NetworkCaptureReplayer.h:45 > + Replayer(Manager& manager) explicit ? > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:73 > + auto replayMode = [] (String mode) -> std::optional<NetworkCaptureMode> { const String&
EWS Watchlist
Comment 3 2018-11-30 15:39:10 PST
Comment on attachment 356240 [details] Patch Attachment 356240 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10220678 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2018-11-30 15:39:11 PST
Created attachment 356252 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-12-01 02:52:56 PST
Comment on attachment 356240 [details] Patch Attachment 356240 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10227416 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2018-12-01 02:53:05 PST
Created attachment 356304 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Note You need to log in before you can comment on or make changes to this bug.