WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 197979
190929
BytecodeGenerator should not force op_get_by_val to be wide within IndexedForInContext
https://bugs.webkit.org/show_bug.cgi?id=190929
Summary
BytecodeGenerator should not force op_get_by_val to be wide within IndexedFor...
Tadeu Zagallo
Reported
2018-10-25 16:23:06 PDT
As part of
https://bugs.webkit.org/show_bug.cgi?id=187373
, when emitting an op_get_by_bal within an IndexedForInContext we force it to be emitted as a wide instruction since we might need to patch the instruction later and we want to guarantee that the alternative value fits in the instruction stream. However, we know the only value that we might use to patch the instruction ahead of time, so we could do do a Fits::check to see if it would fit in a narrow instruction and only force it to be wide otherwise.
Attachments
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2019-05-20 02:30:48 PDT
Right! We should do this :)
Yusuke Suzuki
Comment 2
2019-05-21 03:54:24 PDT
I'll do this as a part of
bug 197979
. *** This bug has been marked as a duplicate of
bug 197979
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug