Bug 189417 - [ews-build] API tests should output result summary in json
Summary: [ews-build] API tests should output result summary in json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-07 10:50 PDT by Aakash Jain
Modified: 2019-10-11 10:55 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (5.75 KB, patch)
2018-09-07 10:55 PDT, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
Patch for landing (5.76 KB, patch)
2018-09-07 11:12 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-09-07 10:50:01 PDT 
API tests should output result in json. This would be useful in easily parsing the errors.
Comment 1 Aakash Jain 2018-09-07 10:55:45 PDT 
Created attachment 349159 [details]
Proposed patch

This is very similar to https://bugs.webkit.org/show_bug.cgi?id=187330 and https://bugs.webkit.org/show_bug.cgi?id=187331
Comment 2 Aakash Jain 2018-09-07 10:57:48 PDT 
Tested in http://ews-build.webkit-uat.org/#/builders/19/builds/18
Comment 3 Lucas Forschler 2018-09-07 11:04:23 PDT 
Comment on attachment 349159 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349159&action=review

> Tools/ChangeLog:3
> +        [ews-build] API tests should output result in json

API tests should output result SUMMARY in json

> Tools/BuildSlaveSupport/ews-build/steps.py:482
> +    jsonFileName = 'api_test_results.json'

jsonFileName = 'api_test_results_summary.json'

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:931
> +        self.jsonFileName = 'api_test_results.json'

api_test_results_summary.json
Comment 4 Aakash Jain 2018-09-07 11:12:08 PDT 
Created attachment 349165 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-09-07 11:49:31 PDT 
Comment on attachment 349165 [details]
Patch for landing

Clearing flags on attachment: 349165

Committed r235789: <https://trac.webkit.org/changeset/235789>
Comment 6 WebKit Commit Bot 2018-09-07 11:49:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-07 11:50:42 PDT 
<rdar://problem/44232647>