Bug 189380 - Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter
Summary: Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-06 15:52 PDT by Michael Saboff
Modified: 2018-09-06 16:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2018-09-06 16:00 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2018-09-06 15:52:58 PDT 
Given that Math.pow(NaN, 0) gives the result of 1, the computed SpeculatedType for ArithPow(NaN, non-NaN) should include Double values.
Comment 1 Michael Saboff 2018-09-06 15:53:24 PDT 
<rdar://problem/42908665>
Comment 2 Michael Saboff 2018-09-06 16:00:21 PDT 
Created attachment 349086 [details]
Patch
Comment 3 Saam Barati 2018-09-06 16:18:30 PDT 
Comment on attachment 349086 [details]
Patch

Let's keep an eye on perf bots after this to ensure this doesn't hurt perf anywhere
Comment 4 Michael Saboff 2018-09-06 16:19:25 PDT 
(In reply to Saam Barati from comment #3)
> Comment on attachment 349086 [details]
> Patch
> 
> Let's keep an eye on perf bots after this to ensure this doesn't hurt perf
> anywhere

Good idea.
Comment 5 WebKit Commit Bot 2018-09-06 16:44:57 PDT 
Comment on attachment 349086 [details]
Patch

Clearing flags on attachment: 349086

Committed r235765: <https://trac.webkit.org/changeset/235765>
Comment 6 WebKit Commit Bot 2018-09-06 16:44:58 PDT 
All reviewed patches have been landed.  Closing bug.