Bug 189359 - Move replaceTrack logic to RTCRtpSender backend
Summary: Move replaceTrack logic to RTCRtpSender backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-06 10:44 PDT by youenn fablet
Modified: 2018-09-06 14:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.49 KB, patch)
2018-09-06 10:47 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews203 for win-future (12.83 MB, application/zip)
2018-09-06 13:41 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-09-06 10:44:31 PDT
This is where it belongs and will not require this hop through the peer connection backend
Comment 1 youenn fablet 2018-09-06 10:47:11 PDT
Created attachment 349044 [details]
Patch
Comment 2 EWS Watchlist 2018-09-06 13:41:10 PDT
Comment on attachment 349044 [details]
Patch

Attachment 349044 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9116790

New failing tests:
fast/workers/worker-exception-during-navigation.html
Comment 3 EWS Watchlist 2018-09-06 13:41:23 PDT
Created attachment 349065 [details]
Archive of layout-test-results from ews203 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 WebKit Commit Bot 2018-09-06 14:14:14 PDT
Comment on attachment 349044 [details]
Patch

Clearing flags on attachment: 349044

Committed r235757: <https://trac.webkit.org/changeset/235757>
Comment 5 WebKit Commit Bot 2018-09-06 14:14:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-06 14:15:34 PDT
<rdar://problem/44196598>