Bug 189347 - Move regress-189185.js under JSTests/wasm.
Summary: Move regress-189185.js under JSTests/wasm.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-06 07:33 PDT by Dominik Inführ
Modified: 2018-09-09 13:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2018-09-06 07:35 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2018-09-06 07:38 PDT, Dominik Inführ 		mark.lam: review-
Details | Formatted Diff | Diff
patch for landing. (1.90 KB, patch)
2018-09-06 11:49 PDT, Mark Lam 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-09-06 07:33:13 PDT 
Disable test when WebAssembly not enabled
Comment 1 Dominik Inführ 2018-09-06 07:35:56 PDT 
Created attachment 349022 [details]
Patch
Comment 2 Dominik Inführ 2018-09-06 07:38:42 PDT 
Created attachment 349023 [details]
Patch
Comment 3 Saam Barati 2018-09-06 07:47:43 PDT 
Comment on attachment 349023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review

> JSTests/stress/regress-189185.js:1
> +//@ skip if !isWebAssemblyEnabled

Why not move this test into the Wasm test directory?
Comment 4 Mark Lam 2018-09-06 09:42:37 PDT 
Comment on attachment 349023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review

>> JSTests/stress/regress-189185.js:1
>> +//@ skip if !isWebAssemblyEnabled
> 
> Why not move this test into the Wasm test directory?

I agree with Saam.  I should have put this test in JSTests/wasm directory.  I just wasn't aware of that option at the time.  Let's move the test there instead.  Thanks.
Comment 5 Mark Lam 2018-09-06 10:59:52 PDT 
Since Dominik hasn't responded yet, and this issue seems to be creating problems with some of our internal testing as well, I'll go ahead and implement the fix.
Comment 6 Mark Lam 2018-09-06 11:49:07 PDT 
Created attachment 349048 [details]
patch for landing.
Comment 7 WebKit Commit Bot 2018-09-06 12:47:23 PDT 
Comment on attachment 349048 [details]
patch for landing.

Rejecting attachment 349048 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 349048, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9117011
Comment 8 Mark Lam 2018-09-06 12:59:52 PDT 
Landed in r235751: <http://trac.webkit.org/r235751>.
Comment 9 Radar WebKit Bug Importer 2018-09-06 13:02:56 PDT 
<rdar://problem/44193122>
Comment 10 Dominik Inführ 2018-09-07 01:27:07 PDT 
Thanks for fixing that!