Bug 189336 - [WinCairo][MiniBrowser][WebKit] REGRESSION(r235398): ASSERTION FAILED: !m_client.didReceiveTitleForFrame
Summary: [WinCairo][MiniBrowser][WebKit] REGRESSION(r235398): ASSERTION FAILED: !m_cli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-06 03:46 PDT by Fujii Hironori
Modified: 2019-07-16 20:52 PDT (History)
4 users (show)

See Also:

Attachments
WIP patch (3.21 KB, patch)
2018-09-06 04:06 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (4.68 KB, patch)
2018-09-06 22:14 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-09-06 03:46:29 PDT 
[WinCairo][MiniBrowser][WebKit] REGRESSION(r235398): ASSERTION FAILED: !m_client.didReceiveTitleForFrame

WinCairo MiniBrowser hits RELEASE_ASSERT failure since r235398.

> ASSERTION FAILED: !m_client.didReceiveTitleForFrame
> c:\webkit\gb\source\webkit\uiprocess\api\c\wkpage.cpp(1050) : WKPageSetPageLoaderClient::LoaderClient::LoaderClient
Comment 1 Fujii Hironori 2018-09-06 04:06:59 PDT 
Created attachment 349016 [details]
WIP patch

Umm, there is no WK2 C API to call back the title. Cocoa and glib WK2 API exist.
Comment 2 Alex Christensen 2018-09-06 09:49:44 PDT 
Looks good if it works for you.  It might be worth adding a PageLoadState::Observer eventually.
Comment 3 Fujii Hironori 2018-09-06 22:14:33 PDT 
Created attachment 349113 [details]
Patch
Comment 4 WebKit Commit Bot 2018-09-07 17:37:25 PDT 
Comment on attachment 349113 [details]
Patch

Clearing flags on attachment: 349113

Committed r235824: <https://trac.webkit.org/changeset/235824>
Comment 5 WebKit Commit Bot 2018-09-07 17:37:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-07 17:38:20 PDT 
<rdar://problem/44246092>
Comment 7 Fujii Hironori 2019-07-16 20:52:58 PDT 
(In reply to Alex Christensen from comment #2)
> Looks good if it works for you.  It might be worth adding a
> PageLoadState::Observer eventually.

Filed: Bug 199848 – [Win][WebKit] Add PageLoadState::Observer C API