Bug 189282 - [CMake] Make TestWebKitAPI dependencies explicit
Summary: [CMake] Make TestWebKitAPI dependencies explicit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-04 16:24 PDT by Don Olmstead
Modified: 2018-09-04 18:53 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.44 KB, patch)
2018-09-04 16:28 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (7.44 KB, patch)
2018-09-04 16:33 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-09-04 16:24:29 PDT 
The config.h file in TestWebKitAPI is for all the Test* builds. This means that TestWTF can technically depend on headers from JavaScriptCore, WebCore and WebKit.
Comment 1 Don Olmstead 2018-09-04 16:28:20 PDT 
Created attachment 348867 [details]
Patch
Comment 2 EWS Watchlist 2018-09-04 16:30:26 PDT 
Attachment 348867 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/CMakeLists.txt:19:  Alphabetical sorting problem. "JavaScriptCoreForwardingHeaders" should be before "WTFForwardingHeaders".  [list/order] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-09-04 16:33:27 PDT 
Created attachment 348872 [details]
Patch
Comment 4 Fujii Hironori 2018-09-04 18:01:35 PDT 
I fixed this issue in Bug 184441. 
How can you reproduce?
Comment 5 Don Olmstead 2018-09-04 18:04:43 PDT 
(In reply to Fujii Hironori from comment #4)
> I fixed this issue in Bug 184441. 
> How can you reproduce?

Have an empty WebKitBuild.

build-webkit --generate-project-only

cd WebKitBuild/Release
ninja TestWTF

Or create a visual studio build and try and build TestWTF first.
Comment 6 Fujii Hironori 2018-09-04 18:23:49 PDT 
Comment on attachment 348872 [details]
Patch

You are right. I fixed a problem only for GTK and WPE. This patch looks good to me.
Comment 7 Don Olmstead 2018-09-04 18:26:13 PDT 
(In reply to Fujii Hironori from comment #6)
> Comment on attachment 348872 [details]
> Patch
> 
> You are right. I fixed a problem only for GTK and WPE. This patch looks good
> to me.

Thanks! This should make it so TestWTF never fails to compile due to missing headers.
Comment 8 WebKit Commit Bot 2018-09-04 18:52:07 PDT 
Comment on attachment 348872 [details]
Patch

Clearing flags on attachment: 348872

Committed r235653: <https://trac.webkit.org/changeset/235653>
Comment 9 WebKit Commit Bot 2018-09-04 18:52:09 PDT 
All reviewed patches have been landed.  Closing bug.