Bug 189281 - Move replaceTrack logic to LibWebRTCPeerConnectionBackend
Summary: Move replaceTrack logic to LibWebRTCPeerConnectionBackend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-04 16:23 PDT by youenn fablet
Modified: 2018-09-05 11:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.83 KB, patch)
2018-09-04 16:26 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (9.83 KB, patch)
2018-09-05 08:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.61 KB, patch)
2018-09-05 10:39 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-09-04 16:23:04 PDT 
Right now it is split between RTCPeerConnection and LibWebRTCPeerConnectionBackend.
This makes it difficult to reason about.
Comment 1 youenn fablet 2018-09-04 16:26:20 PDT 
Created attachment 348866 [details]
Patch
Comment 2 youenn fablet 2018-09-05 08:49:03 PDT 
Created attachment 348926 [details]
Patch
Comment 3 Eric Carlson 2018-09-05 09:58:59 PDT 
Comment on attachment 348926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348926&action=review

> Source/WebCore/ChangeLog:9
> +        This allows maing the logic easier to understand.

Nit: "This allows maing the logic" -> "This makes the logic"

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:412
> +static inline bool tryUpdatingTrackSource(MediaStreamTrack& currentTrack, MediaStreamTrack* newTrack, const Vector<Source>& sources)

It doesn't look like newTrack can be NULL, can you make it a MediaStreamTrack& ?
Comment 4 youenn fablet 2018-09-05 10:39:13 PDT 
Created attachment 348938 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-09-05 11:55:01 PDT 
Comment on attachment 348938 [details]
Patch for landing

Clearing flags on attachment: 348938

Committed r235682: <https://trac.webkit.org/changeset/235682>
Comment 6 WebKit Commit Bot 2018-09-05 11:55:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-05 11:56:21 PDT 
<rdar://problem/44148039>