Bug 189270 - Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
Summary: Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-04 13:01 PDT by youenn fablet
Modified: 2018-09-04 17:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (21.29 KB, patch)
2018-09-04 15:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (21.32 KB, patch)
2018-09-04 16:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-09-04 13:01:37 PDT 
Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
Comment 1 youenn fablet 2018-09-04 15:31:10 PDT 
Created attachment 348857 [details]
Patch
Comment 2 Eric Carlson 2018-09-04 16:21:00 PDT 
Comment on attachment 348857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348857&action=review

> Source/WebCore/ChangeLog:8
> +        Previously, the libwebrtc sender were owned in LibWebRTCMediaEndpoint.

Nit: sender -> senders

> Source/WebCore/ChangeLog:9
> +        This patch makes them owned by LibWebRTCRtpSenderBackend.

Nit: makes them owned by -> makes them be owned by

> Source/WebCore/ChangeLog:11
> +        This will help simplifying the implementation of RTCRtpSender::replaceTrack.

Nit: simplifying -> simplify

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:258
> +        if (m_peerConnectionBackend.shouldOfferAllowToReceive("audio"))

Nit: "audio" -> "audio"_s

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:260
> +        if (m_peerConnectionBackend.shouldOfferAllowToReceive("video"))

Nit: "video" -> "video"_s
Comment 3 youenn fablet 2018-09-04 16:31:51 PDT 
Created attachment 348870 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-09-04 17:04:07 PDT 
Comment on attachment 348870 [details]
Patch for landing

Clearing flags on attachment: 348870

Committed r235649: <https://trac.webkit.org/changeset/235649>
Comment 5 WebKit Commit Bot 2018-09-04 17:04:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-04 17:06:16 PDT 
<rdar://problem/44118910>