Bug 189208 - Web Inspector: imported recordings are unable to be viewed after navigation
Summary: Web Inspector: imported recordings are unable to be viewed after navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-31 13:32 PDT by Devin Rousso
Modified: 2018-09-12 09:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.91 KB, patch)
2018-08-31 13:36 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (30.64 KB, image/png)
2018-09-02 09:59 PDT, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-08-31 13:32:04 PDT 
STEPS TO REPRODUCE:
1. Go to a page with a 2D canvas
2. Take a recording
3. Refresh the page
 => "Canvas #" still shows in the navigation sidebar
4. Click back to the "overview" (the path component should've changed to "Imported Recordings"
 => No way to look at the imported recording (you'd have to select a canvas, and then click the canvas path component dropdown to select the "Imported Recordings" folder)
Comment 1 Devin Rousso 2018-08-31 13:36:58 PDT 
Created attachment 348668 [details]
Patch
Comment 2 Matt Baker 2018-08-31 14:12:49 PDT 
Nice! Screenshots showing new UI would be great.
Comment 3 Devin Rousso 2018-09-02 09:59:34 PDT 
Created attachment 348738 [details]
[Image] After Patch is applied

(In reply to Matt Baker from comment #2)
> Nice! Screenshots showing new UI would be great.
Sorry, my laptop ran out of battery almost immediately after I uploaded the patch 😅
Comment 4 Joseph Pecoraro 2018-09-11 18:35:14 PDT 
Comment on attachment 348668 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2018-09-12 09:11:07 PDT 
Comment on attachment 348668 [details]
Patch

Clearing flags on attachment: 348668

Committed r235937: <https://trac.webkit.org/changeset/235937>
Comment 6 WebKit Commit Bot 2018-09-12 09:11:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-12 09:12:22 PDT 
<rdar://problem/44385390>