Bug 189183 - slotchange-event-bubbling.html fails in Chrome & Firefox
Summary: slotchange-event-bubbling.html fails in Chrome & Firefox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 189144
  Show dependency treegraph
 
Reported: 2018-08-30 21:38 PDT by Ryosuke Niwa
Modified: 2018-08-31 13:42 PDT (History)
6 users (show)

See Also:


Attachments
Fixes the test (6.89 KB, patch)
2018-08-30 21:43 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-08-30 21:38:37 PDT
There is a bug in slotchange-event-bubbling.html such that it fails in Chrome & Firefox.
We would start failing this test as well once the bug 189144 is fixed.
Comment 1 Ryosuke Niwa 2018-08-30 21:43:03 PDT
Created attachment 348600 [details]
Fixes the test
Comment 2 Chris Dumez 2018-08-31 13:32:56 PDT
Comment on attachment 348600 [details]
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=348600&action=review

> LayoutTests/ChangeLog:8
> +        slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes.

Typo: assinged

> LayoutTests/ChangeLog:10
> +        Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask

Typo: implements -> implement / fails -> fail

> LayoutTests/ChangeLog:13
> +        Fixed the test by manually waiting for the current microtask queue is emptied after constructing

is emptied -> to be emptied?
Comment 3 Ryosuke Niwa 2018-08-31 13:39:25 PDT
(In reply to Chris Dumez from comment #2)
> Comment on attachment 348600 [details]
> Fixes the test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348600&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes.
> 
> Typo: assinged

Fixed.

> > LayoutTests/ChangeLog:10
> > +        Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask
> 
> Typo: implements -> implement / fails -> fail

Fixed.

> > LayoutTests/ChangeLog:13
> > +        Fixed the test by manually waiting for the current microtask queue is emptied after constructing
> 
> is emptied -> to be emptied?

Fixed.
Comment 4 Ryosuke Niwa 2018-08-31 13:41:59 PDT
Committed r235568: <https://trac.webkit.org/changeset/235568>
Comment 5 Radar WebKit Bug Importer 2018-08-31 13:42:17 PDT
<rdar://problem/43953435>