Bug 189182 - Move LibWebRTCMediaEndpoint data channel code to LibWebRTCDataChannelHandler
Summary: Move LibWebRTCMediaEndpoint data channel code to LibWebRTCDataChannelHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 21:26 PDT by youenn fablet
Modified: 2018-08-31 08:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.67 KB, patch)
2018-08-30 21:28 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (9.81 KB, patch)
2018-08-30 21:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-08-30 21:26:38 PDT 
Refactoring to ease future developments.
Comment 1 youenn fablet 2018-08-30 21:28:37 PDT 
Created attachment 348593 [details]
Patch
Comment 2 youenn fablet 2018-08-30 21:45:20 PDT 
Created attachment 348601 [details]
Patch
Comment 3 Alejandro G. Castro 2018-08-31 06:26:05 PDT 
Comment on attachment 348601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348601&action=review

LGTM

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:750
> +        auto& connection = protectedThis->m_peerConnectionBackend.connection();
> +        connection.fireEvent(LibWebRTCDataChannelHandler::channelEvent(*connection.scriptExecutionContext(), WTFMove(dataChannel)));

You can avoid the connection variable.
Comment 4 youenn fablet 2018-08-31 08:25:04 PDT 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:750
> > +        auto& connection = protectedThis->m_peerConnectionBackend.connection();
> > +        connection.fireEvent(LibWebRTCDataChannelHandler::channelEvent(*connection.scriptExecutionContext(), WTFMove(dataChannel)));
> 
> You can avoid the connection variable.

Right, I think it reads better as two lines though.
Comment 5 WebKit Commit Bot 2018-08-31 08:52:04 PDT 
Comment on attachment 348601 [details]
Patch

Clearing flags on attachment: 348601

Committed r235552: <https://trac.webkit.org/changeset/235552>
Comment 6 WebKit Commit Bot 2018-08-31 08:52:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-31 08:53:33 PDT 
<rdar://problem/43941822>