Bug 189173 - convertToRegExpMatchFastGlobal must use KnownString as the child use kind
Summary: convertToRegExpMatchFastGlobal must use KnownString as the child use kind
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 14:05 PDT by Saam Barati
Modified: 2018-08-31 00:45 PDT (History)
13 users (show)

See Also:

Attachments
patch (6.22 KB, patch)
2018-08-30 14:15 PDT, Saam Barati 		saam: review-
Details | Formatted Diff | Diff
patch (7.15 KB, patch)
2018-08-30 14:33 PDT, Saam Barati 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing (7.16 KB, patch)
2018-08-30 16:07 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-08-30 14:05:23 PDT 
We emit this node after a node that does side effects, so it's no longer valid to exit at that node. We also emit type checks on these edges before this node and before the side effect, so KnownString is the valid UseKind to use.
Comment 1 Saam Barati 2018-08-30 14:06:03 PDT 
<rdar://problem/43501645>
Comment 2 Saam Barati 2018-08-30 14:15:54 PDT 
Created attachment 348547 [details]
patch
Comment 3 Saam Barati 2018-08-30 14:25:47 PDT 
Comment on attachment 348547 [details]
patch

Need to fix some assertions
Comment 4 Saam Barati 2018-08-30 14:33:43 PDT 
Created attachment 348552 [details]
patch
Comment 5 Michael Saboff 2018-08-30 14:43:19 PDT 
Comment on attachment 348552 [details]
patch

r=me
Comment 6 Saam Barati 2018-08-30 16:07:02 PDT 
Created attachment 348562 [details]
patch for landing
Comment 7 WebKit Commit Bot 2018-08-31 00:45:10 PDT 
Comment on attachment 348562 [details]
patch for landing

Clearing flags on attachment: 348562

Committed r235538: <https://trac.webkit.org/changeset/235538>
Comment 8 WebKit Commit Bot 2018-08-31 00:45:12 PDT 
All reviewed patches have been landed.  Closing bug.