Bug 189160 - WebAudioBufferList.cpp/.h is named as cocoa/WebAudioBufferList.cpp/.h
Summary: WebAudioBufferList.cpp/.h is named as cocoa/WebAudioBufferList.cpp/.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 11:00 PDT by youenn fablet
Modified: 2018-08-31 12:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.64 KB, patch)
2018-08-30 11:24 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (15.18 KB, patch)
2018-08-30 12:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing (14.18 KB, patch)
2018-08-30 15:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.98 KB, patch)
2018-08-30 21:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (15.12 KB, patch)
2018-08-31 11:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-08-30 11:00:13 PDT 
Updating the XCode project file then modifies unnecessarily it for these files
Comment 1 youenn fablet 2018-08-30 11:24:09 PDT 
Created attachment 348516 [details]
Patch
Comment 2 youenn fablet 2018-08-30 12:51:47 PDT 
Created attachment 348533 [details]
Patch
Comment 3 youenn fablet 2018-08-30 15:53:07 PDT 
Created attachment 348559 [details]
Rebasing
Comment 4 youenn fablet 2018-08-30 21:53:35 PDT 
Created attachment 348604 [details]
Patch
Comment 5 WebKit Commit Bot 2018-08-31 09:35:15 PDT 
Comment on attachment 348604 [details]
Patch

Rejecting attachment 348604 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 348604, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348604&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189160&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 348604 from bug 189160.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348604
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PlatformMac.cmake
patching file Source/WebCore/SourcesCocoa.txt
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 succeeded at 1086 (offset -2 lines).
Hunk #2 succeeded at 1096 (offset -2 lines).
Hunk #3 succeeded at 3959 (offset -2 lines).
Hunk #4 FAILED at 4059.
Hunk #5 succeeded at 7254 (offset -3 lines).
Hunk #6 succeeded at 13128 (offset -3 lines).
Hunk #7 succeeded at 13184 (offset -3 lines).
Hunk #8 FAILED at 13365.
Hunk #9 FAILED at 24562.
Hunk #10 succeeded at 27249 (offset -5 lines).
Hunk #11 FAILED at 27274.
Hunk #12 succeeded at 29346 (offset -6 lines).
Hunk #13 succeeded at 29995 (offset -6 lines).
Hunk #14 FAILED at 31363.
5 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9051182
Comment 6 youenn fablet 2018-08-31 11:25:43 PDT 
Created attachment 348656 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-08-31 12:13:13 PDT 
Comment on attachment 348656 [details]
Patch for landing

Clearing flags on attachment: 348656

Committed r235563: <https://trac.webkit.org/changeset/235563>
Comment 8 WebKit Commit Bot 2018-08-31 12:13:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-08-31 12:14:18 PDT 
<rdar://problem/43950658>