Bug 189159 - [MediaStream] Remove AVMediaCaptureSource
Summary: [MediaStream] Remove AVMediaCaptureSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 10:45 PDT by Eric Carlson
Modified: 2018-08-31 05:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (61.53 KB, patch)
2018-08-30 10:52 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (55.44 KB, patch)
2018-08-30 11:30 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (39.31 KB, patch)
2018-08-30 12:38 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (39.72 KB, patch)
2018-08-30 14:30 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (42.26 KB, patch)
2018-08-31 05:04 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-08-30 10:45:43 PDT 
We only use AVCapture for video now, so there is no need for base class.
Comment 1 Eric Carlson 2018-08-30 10:52:52 PDT 
Created attachment 348508 [details]
Patch
Comment 2 Eric Carlson 2018-08-30 11:30:57 PDT 
Created attachment 348519 [details]
Patch for landing
Comment 3 Eric Carlson 2018-08-30 12:38:22 PDT 
Created attachment 348529 [details]
Patch for landing
Comment 4 Eric Carlson 2018-08-30 14:30:12 PDT 
Created attachment 348551 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-08-30 16:40:44 PDT 
Comment on attachment 348551 [details]
Patch for landing

Rejecting attachment 348551 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 348551, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/9041724
Comment 6 Eric Carlson 2018-08-31 05:04:46 PDT 
Created attachment 348635 [details]
Patch for landing
Comment 7 Radar WebKit Bug Importer 2018-08-31 05:05:01 PDT 
<rdar://problem/43935721>
Comment 8 WebKit Commit Bot 2018-08-31 05:43:39 PDT 
Comment on attachment 348635 [details]
Patch for landing

Clearing flags on attachment: 348635

Committed r235549: <https://trac.webkit.org/changeset/235549>
Comment 9 WebKit Commit Bot 2018-08-31 05:43:41 PDT 
All reviewed patches have been landed.  Closing bug.