Bug 189092 - [iOS] Update color picker to match design feedback
Summary: [iOS] Update color picker to match design feedback
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-29 11:49 PDT by Aditya Keerthi
Modified: 2021-11-01 12:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (28.88 KB, patch)
2018-08-29 12:08 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.35 MB, application/zip)
2018-08-29 14:06 PDT, EWS Watchlist 		no flags Details
Patch (29.61 KB, patch)
2018-08-29 17:13 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2018-08-29 11:49:14 PDT 
The color well on iOS should look more like macOS.

iPad: The corners of the color picker should not be rounded.

iPhone: The color picker should not have an edge-to-edge design and should respect the safe area on iPhone X.
Comment 1 Aditya Keerthi 2018-08-29 12:08:55 PDT 
Created attachment 348419 [details]
Patch
Comment 2 EWS Watchlist 2018-08-29 14:06:38 PDT 
Comment on attachment 348419 [details]
Patch

Attachment 348419 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9026087

New failing tests:
fast/forms/color/input-appearance-color.html
Comment 3 EWS Watchlist 2018-08-29 14:06:40 PDT 
Created attachment 348429 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 4 Aditya Keerthi 2018-08-29 17:13:44 PDT 
Created attachment 348453 [details]
Patch
Comment 5 Alex Christensen 2021-11-01 12:51:09 PDT 
Comment on attachment 348453 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.