Bug 189073 - IDBDatabase should not return true to hasPendingActivity after being stopped
Summary: IDBDatabase should not return true to hasPendingActivity after being stopped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-28 20:32 PDT by youenn fablet
Modified: 2018-08-28 21:53 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2018-08-28 20:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-08-28 20:32:36 PDT 
IDBDatabase should not return true to hasPendingActivity after being stopped
Comment 1 youenn fablet 2018-08-28 20:36:53 PDT 
Created attachment 348384 [details]
Patch
Comment 2 Darin Adler 2018-08-28 20:39:23 PDT 
Comment on attachment 348384 [details]
Patch

No way to make a regression test?
Comment 3 youenn fablet 2018-08-28 21:26:01 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 348384 [details]
> Patch
> 
> No way to make a regression test?

AFAIUI, IDBDatabase::hasPendingActivity will stop returning true once transactions are finalized which will happen ultimately, but not always before GC calls IDBDatabase::hasPendingActivity for the first time.

This patch makes IDBDatabase GC-collectable sooner but I do not think it makes some leaked IDBDatabase no longer leaking, so there is no easy way to add a test for that change.

This will be captured with bug 189018, which asserts that a stopped ActiveDOMObject hasPendingActivity to return false. Without this patch, some IDB tests would crash.
Comment 4 WebKit Commit Bot 2018-08-28 21:52:52 PDT 
Comment on attachment 348384 [details]
Patch

Clearing flags on attachment: 348384

Committed r235456: <https://trac.webkit.org/changeset/235456>
Comment 5 WebKit Commit Bot 2018-08-28 21:52:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-28 21:53:24 PDT 
<rdar://problem/43828788>