Bug 189004 - [Attachment Support] Remove WebCore::AttachmentDisplayOptions and friends
Summary: [Attachment Support] Remove WebCore::AttachmentDisplayOptions and friends
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2018-08-27 14:20 PDT by Wenson Hsieh
Modified: 2018-08-27 17:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (34.09 KB, patch)
2018-08-27 14:55 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for EWS (35.03 KB, patch)
2018-08-27 15:19 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-08-27 14:20:41 PDT 
This class no longer serves a purpose, now that we have a plan for inline image and video attachment presentation that does not involve using _WKAttachmentDisplayOptions.
Comment 1 Wenson Hsieh 2018-08-27 14:55:43 PDT 
Created attachment 348205 [details]
Patch
Comment 2 Wenson Hsieh 2018-08-27 15:19:38 PDT 
Created attachment 348210 [details]
Patch for EWS
Comment 3 WebKit Commit Bot 2018-08-27 17:28:58 PDT 
Comment on attachment 348210 [details]
Patch for EWS

Clearing flags on attachment: 348210

Committed r235414: <https://trac.webkit.org/changeset/235414>
Comment 4 WebKit Commit Bot 2018-08-27 17:28:59 PDT 
All reviewed patches have been landed.  Closing bug.